Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(730)

Unified Diff: runtime/observatory/tests/service/udp_socket_service_test.dart

Issue 1343033002: Use cammelCase for all service extension variables (Closed) Base URL: https://github.com/dart-lang/sdk.git@master
Patch Set: Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/observatory/tests/service/tcp_socket_service_test.dart ('k') | sdk/lib/io/io_resource_info.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/observatory/tests/service/udp_socket_service_test.dart
diff --git a/runtime/observatory/tests/service/udp_socket_service_test.dart b/runtime/observatory/tests/service/udp_socket_service_test.dart
index 6b4b3b9e24241a60e2bcaee8deca1d1b64905cec..49ff5e4fc1d0af72dbe67f498039dae538946587 100644
--- a/runtime/observatory/tests/service/udp_socket_service_test.dart
+++ b/runtime/observatory/tests/service/udp_socket_service_test.dart
@@ -40,42 +40,42 @@ var udpTests = [
var server = await isolate.invokeRpcNoUpgrade(
'__getSocketByID', { 'id' : result['data'][0]['id'] });
expect(server['id'], equals(result['data'][0]['id']));
- expect(server['remote_port'], equals('NA'));
- expect(server['remote_host'], equals('NA'));
+ expect(server['remotePort'], equals('NA'));
+ expect(server['remoteHost'], equals('NA'));
expect(server['listening'], isFalse);
- expect(server['socket_type'], equals('UDP'));
+ expect(server['socketType'], equals('UDP'));
expect(server['port'], greaterThanOrEqualTo(1024));
// Stopwatch resolution on windows makes us sometimes report 0;
if (io.Platform.isWindows) {
- expect(server['last_read'], greaterThanOrEqualTo(0));
+ expect(server['lastRead'], greaterThanOrEqualTo(0));
} else {
- expect(server['last_read'], greaterThan(0));
+ expect(server['lastRead'], greaterThan(0));
}
- expect(server['total_read'], equals(6));
- expect(server['last_write'], equals(0));
- expect(server['total_written'], equals(0));
- expect(server['write_count'], equals(0));
- expect(server['read_count'], greaterThanOrEqualTo(1));
+ expect(server['totalRead'], equals(6));
+ expect(server['lastWrite'], equals(0));
+ expect(server['totalWritten'], equals(0));
+ expect(server['writeCount'], equals(0));
+ expect(server['readCount'], greaterThanOrEqualTo(1));
var client = await isolate.invokeRpcNoUpgrade(
'__getSocketByID', { 'id' : result['data'][1]['id'] });
expect(client['id'], equals(result['data'][1]['id']));
- expect(client['remote_port'], equals('NA'));
- expect(client['remote_host'], equals('NA'));
+ expect(client['remotePort'], equals('NA'));
+ expect(client['remoteHost'], equals('NA'));
expect(client['listening'], isFalse);
- expect(client['socket_type'], equals('UDP'));
+ expect(client['socketType'], equals('UDP'));
expect(client['port'], greaterThanOrEqualTo(1024));
- expect(client['last_read'], equals(0));
- expect(client['total_read'], equals(0));
+ expect(client['lastRead'], equals(0));
+ expect(client['totalRead'], equals(0));
// Stopwatch resolution on windows makes us sometimes report 0;
if (io.Platform.isWindows) {
- expect(client['last_write'], greaterThanOrEqualTo(0));
+ expect(client['lastWrite'], greaterThanOrEqualTo(0));
} else {
- expect(client['last_write'], greaterThan(0));
+ expect(client['lastWrite'], greaterThan(0));
}
- expect(client['total_written'], equals(6));
- expect(client['write_count'], greaterThanOrEqualTo(1));
- expect(client['read_count'], equals(0));
+ expect(client['totalWritten'], equals(6));
+ expect(client['writeCount'], greaterThanOrEqualTo(1));
+ expect(client['readCount'], equals(0));
},
];
« no previous file with comments | « runtime/observatory/tests/service/tcp_socket_service_test.dart ('k') | sdk/lib/io/io_resource_info.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698