runtime/observatory/tests/service/tcp_socket_closing_service_test.dart - Issue 1343033002: Use cammelCase for all service extension variables

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/observatory/tests/service/tcp_socket_closing_service_test.dart

Issue 1343033002: Use cammelCase for all service extension variables (Closed) Base URL: https://github.com/dart-lang/sdk.git@master

Patch Set: Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « runtime/observatory/tests/service/process_service_test.dart ('k') | runtime/observatory/tests/service/tcp_socket_service_test.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: runtime/observatory/tests/service/tcp_socket_closing_service_test.dart

diff --git a/runtime/observatory/tests/service/tcp_socket_closing_service_test.dart b/runtime/observatory/tests/service/tcp_socket_closing_service_test.dart

index aef55714c7445c9448a4660e0eaf94118160b351..20a9b769c38c760733ea05c8629b66de35b38c5d 100644

--- a/runtime/observatory/tests/service/tcp_socket_closing_service_test.dart

+++ b/runtime/observatory/tests/service/tcp_socket_closing_service_test.dart

@@ -62,12 +62,12 @@ var tests = [

var server = await isolate.invokeRpcNoUpgrade(

'__getSocketByID', { 'id' : result['data'][0]['id'] });

expect(server['listening'], isTrue);

- expect(server['last_read'], equals(0));

- expect(server['total_read'], equals(0));

- expect(server['last_write'], equals(0));

- expect(server['total_written'], equals(0));

- expect(server['write_count'], equals(0));

- expect(server['read_count'], equals(0));

+ expect(server['lastRead'], equals(0));

+ expect(server['totalRead'], equals(0));

+ expect(server['lastWrite'], equals(0));

+ expect(server['totalWritten'], equals(0));

+ expect(server['writeCount'], equals(0));

+ expect(server['readCount'], equals(0));

];