Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(32)

Issue 134303003: Reland: Password manager: Gnome support for Public Suffix List matching (Closed)

Created:
6 years, 11 months ago by vabr (Chromium)
Modified:
6 years, 11 months ago
Reviewers:
engedy, Garrett Casto
CC:
chromium-reviews
Visibility:
Public.

Description

Reland: Password manager: Gnome support for Public Suffix List matching This CL: * Fixes a memory leak of the previous attempt at https://codereview.chromium.org/123223003 * Enables Public Suffix List (PSL) general utilities on Linux. * Enables PSL flag for Linux. * Adds Gnome Keyring support for searching and filtering multiple origins, including UMA metrics and a unit test. The first patch set is identical to https://codereview.chromium.org/123223003, so that the fix of the leak can be viewed by diffing against that. TBR=gcasto@chromium.org BUG=324291 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=244494

Patch Set 1 #

Patch Set 2 : Add scoped_ptr #

Unified diffs Side-by-side diffs Delta from patch set Stats (+135 lines, -13 lines) Patch
M chrome/browser/about_flags.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/password_manager/native_backend_gnome_x.cc View 1 12 chunks +53 lines, -9 lines 0 comments Download
M chrome/browser/password_manager/native_backend_gnome_x_unittest.cc View 6 chunks +80 lines, -2 lines 0 comments Download
M chrome/browser/password_manager/psl_matching_helper.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5 (0 generated)
vabr (Chromium)
Hi Balazs, Could you please review the diff of patch set 2 against 1 (7 ...
6 years, 11 months ago (2014-01-13 10:12:19 UTC) #1
engedy
On 2014/01/13 10:12:19, vabr (Chromium) wrote: > Hi Balazs, > > Could you please review ...
6 years, 11 months ago (2014-01-13 10:19:57 UTC) #2
vabr (Chromium)
Thanks, Balazs. linux_asan passed on trybots, so I'm TBR-ing Garrett now, and sending to CQ. ...
6 years, 11 months ago (2014-01-13 11:02:24 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/vabr@chromium.org/134303003/40001
6 years, 11 months ago (2014-01-13 11:03:12 UTC) #4
commit-bot: I haz the power
6 years, 11 months ago (2014-01-13 12:27:06 UTC) #5
Message was sent while issue was closed.
Change committed as 244494

Powered by Google App Engine
This is Rietveld 408576698