Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(548)

Unified Diff: pkg/compiler/lib/src/js_emitter/parameter_stub_generator.dart

Issue 1342933006: Rename ReceiverMask and ReceiverMaskSet and update comments. (Closed) Base URL: https://github.com/dart-lang/sdk.git@master
Patch Set: Fix after rebase Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pkg/compiler/lib/src/js_emitter/parameter_stub_generator.dart
diff --git a/pkg/compiler/lib/src/js_emitter/parameter_stub_generator.dart b/pkg/compiler/lib/src/js_emitter/parameter_stub_generator.dart
index ed3183346c8639be95a6c701460fa8886abc1610..f632f90e943e1c945fdf4a9cd2f365bdd42e3f3f 100644
--- a/pkg/compiler/lib/src/js_emitter/parameter_stub_generator.dart
+++ b/pkg/compiler/lib/src/js_emitter/parameter_stub_generator.dart
@@ -60,8 +60,8 @@ class ParameterStubGenerator {
// If the method is intercepted, we need to also pass the actual receiver.
int extraArgumentCount = isInterceptedMethod ? 1 : 0;
// Use '$receiver' to avoid clashes with other parameter names. Using
- // '$receiver' works because namer.safeVariableName used for getting parameter
- // names never returns a name beginning with a single '$'.
+ // '$receiver' works because namer.safeVariableName used for getting
+ // parameter names never returns a name beginning with a single '$'.
String receiverArgumentName = r'$receiver';
// The parameters that this stub takes.
@@ -200,14 +200,14 @@ class ParameterStubGenerator {
// The set of selectors that apply to `member`. For example, for
// a member `foo(x, [y])` the following selectors may apply:
// `foo(x)`, and `foo(x, y)`.
- Map<Selector, ReceiverMaskSet> selectors;
+ Map<Selector, SelectorConstraints> selectors;
// The set of selectors that apply to `member` if it's name was `call`.
// This happens when a member is torn off. In that case calls to the
// function use the name `call`, and we must be able to handle every
// `call` invocation that matches the signature. For example, for
// a member `foo(x, [y])` the following selectors would be possible
// call-selectors: `call(x)`, and `call(x, y)`.
- Map<Selector, ReceiverMaskSet> callSelectors;
+ Map<Selector, SelectorConstraints> callSelectors;
// Only instance members (not static methods) need stubs.
if (member.isInstanceMember) {
@@ -220,9 +220,9 @@ class ParameterStubGenerator {
}
assert(emptySelectorSet.isEmpty);
- if (selectors == null) selectors = const <Selector, ReceiverMaskSet>{};
+ if (selectors == null) selectors = const <Selector, SelectorConstraints>{};
if (callSelectors == null) callSelectors =
- const <Selector, ReceiverMaskSet>{};
+ const <Selector, SelectorConstraints>{};
List<ParameterStubMethod> stubs = <ParameterStubMethod>[];
« no previous file with comments | « pkg/compiler/lib/src/js_emitter/js_emitter.dart ('k') | pkg/compiler/lib/src/js_emitter/program_builder/program_builder.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698