Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(477)

Issue 1342933004: ChromeVox shouldn't update its active range for an alert event. (Closed)

Created:
5 years, 3 months ago by dmazzoni
Modified:
5 years, 2 months ago
CC:
chromium-reviews, oshima+watch_chromium.org, plundblad+watch_chromium.org, aboxhall+watch_chromium.org, nektar+watch_chromium.org, yuzo+watch_chromium.org, je_julie, arv+watch_chromium.org, dtseng+watch_chromium.org, dmazzoni+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@jdonnelly
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

ChromeVox shouldn't update its active range for an alert event. BUG=457029 Committed: https://crrev.com/c02d7e0e66d3b41bf1b1d4559685689d6be0bc9b Cr-Commit-Position: refs/heads/master@{#348910}

Patch Set 1 #

Patch Set 2 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -1 line) Patch
M chrome/browser/resources/chromeos/chromevox/cvox2/background/background.js View 2 chunks +21 lines, -1 line 0 comments Download

Depends on Patchset:

Messages

Total messages: 13 (5 generated)
dmazzoni
5 years, 3 months ago (2015-09-14 23:43:46 UTC) #2
Peter Lundblad
lgtm
5 years, 3 months ago (2015-09-15 07:47:23 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1342933004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1342933004/1
5 years, 3 months ago (2015-09-15 07:47:35 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/99772)
5 years, 3 months ago (2015-09-15 07:57:00 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1342933004/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1342933004/20001
5 years, 3 months ago (2015-09-15 16:18:53 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 3 months ago (2015-09-15 16:44:31 UTC) #11
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/c02d7e0e66d3b41bf1b1d4559685689d6be0bc9b Cr-Commit-Position: refs/heads/master@{#348910}
5 years, 3 months ago (2015-09-15 16:45:05 UTC) #12
commit-bot: I haz the power
5 years, 2 months ago (2015-09-23 12:45:57 UTC) #13
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/c02d7e0e66d3b41bf1b1d4559685689d6be0bc9b
Cr-Commit-Position: refs/heads/master@{#348910}

Powered by Google App Engine
This is Rietveld 408576698