Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(850)

Issue 134293002: Remove suppression of PointerLockController uninitialized members. (Closed)

Created:
6 years, 11 months ago by scheib
Modified:
6 years, 11 months ago
Reviewers:
Lei Zhang
CC:
chromium-reviews, glider+watch_chromium.org, timurrrr+watch_chromium.org, bruening+watch_chromium.org
Visibility:
Public.

Description

Remove suppression of PointerLockController uninitialized members. The "conditional jump or move depends on uninitialised value(s)" error triggered in WebCore::Document::webkitPointerLockElement() in Valgrind has been fixed in Blink r164898. Removing suppression. BUG=293049 NOTRY=true Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=244450

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -8 lines) Patch
M tools/valgrind/memcheck/suppressions.txt View 1 chunk +0 lines, -8 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
scheib
Hey. ;) I had the same change ready, just waiting for roll.
6 years, 11 months ago (2014-01-10 21:51:11 UTC) #1
Lei Zhang
lgtm I closed mine
6 years, 11 months ago (2014-01-10 21:57:58 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/scheib@chromium.org/134293002/1
6 years, 11 months ago (2014-01-12 21:17:56 UTC) #3
commit-bot: I haz the power
6 years, 11 months ago (2014-01-12 22:00:42 UTC) #4
Message was sent while issue was closed.
Change committed as 244450

Powered by Google App Engine
This is Rietveld 408576698