Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(490)

Issue 13429004: Implement new methods to replace GetResourceList on GData WAPI. (Closed)

Created:
7 years, 8 months ago by hidehiko
Modified:
7 years, 8 months ago
Reviewers:
hashimoto, kinaba
CC:
chromium-reviews, tfarina, achuith+watch_chromium.org
Base URL:
http://git.chromium.org/chromium/src.git@b160932_move_parse_resource_list_and_run
Visibility:
Public.

Description

Implement new methods to replace GetResourceList on GData WAPI. This CL implements the new methods in GDataWapiService. Because the GData WAPI will be deprecated, so instead of splitting GetResourceListOperation, keeping it as is but set some default parameters in GDataWapiService. The new methods are not used yet, but will be soon used. BUG=160932 TEST=Ran unit_tests Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=192524

Patch Set 1 #

Total comments: 2

Patch Set 2 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+65 lines, -12 lines) Patch
M chrome/browser/google_apis/gdata_wapi_service.cc View 1 5 chunks +65 lines, -12 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
hidehiko
This CL is based on 13619003. Thank you for your review in advance, - hidehiko
7 years, 8 months ago (2013-04-04 08:18:40 UTC) #1
kinaba
lgtm
7 years, 8 months ago (2013-04-04 08:23:33 UTC) #2
hashimoto
lgtm https://codereview.chromium.org/13429004/diff/1/chrome/browser/google_apis/gdata_wapi_service.cc File chrome/browser/google_apis/gdata_wapi_service.cc (right): https://codereview.chromium.org/13429004/diff/1/chrome/browser/google_apis/gdata_wapi_service.cc#newcode211 chrome/browser/google_apis/gdata_wapi_service.cc:211: false, // shared_with_me nit: Please be consistent to ...
7 years, 8 months ago (2013-04-04 09:24:44 UTC) #3
hidehiko
Thank you for your review. Sending to CQ. https://codereview.chromium.org/13429004/diff/1/chrome/browser/google_apis/gdata_wapi_service.cc File chrome/browser/google_apis/gdata_wapi_service.cc (right): https://codereview.chromium.org/13429004/diff/1/chrome/browser/google_apis/gdata_wapi_service.cc#newcode211 chrome/browser/google_apis/gdata_wapi_service.cc:211: false, ...
7 years, 8 months ago (2013-04-05 05:17:55 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hidehiko@chromium.org/13429004/6001
7 years, 8 months ago (2013-04-05 05:18:07 UTC) #5
commit-bot: I haz the power
7 years, 8 months ago (2013-04-05 07:24:44 UTC) #6
Message was sent while issue was closed.
Change committed as 192524

Powered by Google App Engine
This is Rietveld 408576698