Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(150)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1342873002: Small logic change to StateStore::Transaction::ClearAll (Closed)

Created:
5 years, 3 months ago by proberge
Modified:
5 years, 3 months ago
Reviewers:
grt (UTC plus 2)
CC:
chromium-reviews, grt+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Small logic change to StateStore::Transaction::ClearAll BUG=530675 Committed: https://crrev.com/0c3b55f4e76aafab2ae737964abebca30b23029b Cr-Commit-Position: refs/heads/master@{#348733}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Add unit test #

Unified diffs Side-by-side diffs Delta from patch set Stats (+34 lines, -6 lines) Patch
M chrome/browser/safe_browsing/incident_reporting/state_store.cc View 1 chunk +3 lines, -6 lines 0 comments Download
M chrome/browser/safe_browsing/incident_reporting/state_store_unittest.cc View 1 1 chunk +31 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (2 generated)
proberge
5 years, 3 months ago (2015-09-14 18:39:09 UTC) #2
grt (UTC plus 2)
https://codereview.chromium.org/1342873002/diff/1/chrome/browser/safe_browsing/incident_reporting/state_store.cc File chrome/browser/safe_browsing/incident_reporting/state_store.cc (right): https://codereview.chromium.org/1342873002/diff/1/chrome/browser/safe_browsing/incident_reporting/state_store.cc#newcode66 chrome/browser/safe_browsing/incident_reporting/state_store.cc:66: void StateStore::Transaction::ClearAll() { looks like there's no unittest for ...
5 years, 3 months ago (2015-09-14 18:42:39 UTC) #3
proberge
https://codereview.chromium.org/1342873002/diff/1/chrome/browser/safe_browsing/incident_reporting/state_store.cc File chrome/browser/safe_browsing/incident_reporting/state_store.cc (right): https://codereview.chromium.org/1342873002/diff/1/chrome/browser/safe_browsing/incident_reporting/state_store.cc#newcode66 chrome/browser/safe_browsing/incident_reporting/state_store.cc:66: void StateStore::Transaction::ClearAll() { On 2015/09/14 18:42:39, grt wrote: > ...
5 years, 3 months ago (2015-09-14 19:59:52 UTC) #4
grt (UTC plus 2)
nice! lgtm.
5 years, 3 months ago (2015-09-14 20:38:57 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1342873002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1342873002/20001
5 years, 3 months ago (2015-09-14 20:44:32 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 3 months ago (2015-09-14 21:58:39 UTC) #8
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/0c3b55f4e76aafab2ae737964abebca30b23029b Cr-Commit-Position: refs/heads/master@{#348733}
5 years, 3 months ago (2015-09-14 21:59:21 UTC) #9
commit-bot: I haz the power
5 years, 3 months ago (2015-09-23 12:37:48 UTC) #10
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/0c3b55f4e76aafab2ae737964abebca30b23029b
Cr-Commit-Position: refs/heads/master@{#348733}

Powered by Google App Engine
This is Rietveld 408576698