Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(318)

Issue 1342833004: Enable DevTools method for cross-process memory notification suppressing (Closed)

Created:
5 years, 3 months ago by petrcermak
Modified:
5 years, 3 months ago
Reviewers:
pfeldman
CC:
chromium-reviews, darin-cc_chromium.org, jam, yurys, pfeldman, devtools-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Enable DevTools method for cross-process memory notification suppressing This patch is the third part of a 3-sided patch which adds Memory.setPressureNotificationsSuppressed method to DevTools API: 1. Add DevTools method for cross-process memory notification suppressing https://codereview.chromium.org/1336363002/ [Chromium] 2. Add DevTools method for cross-process memory notification suppressing https://codereview.chromium.org/1311343007/ [Blink] 3. Enable DevTools method for cross-process memory notification suppressing (this patch) [Chromium] Proposal: https://goo.gl/cZFdH3 BUG=516776

Patch Set 1 #

Patch Set 2 : Remove asynchronous callback #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -0 lines) Patch
M content/browser/devtools/browser_devtools_agent_host.h View 2 chunks +2 lines, -0 lines 0 comments Download
M content/browser/devtools/browser_devtools_agent_host.cc View 3 chunks +3 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
petrcermak
Hi, please review this small patch. Thanks, Petr
5 years, 3 months ago (2015-09-17 16:15:48 UTC) #3
pfeldman
lgtm
5 years, 3 months ago (2015-09-17 19:12:42 UTC) #4
petrcermak
5 years, 3 months ago (2015-09-24 13:20:14 UTC) #5
Message was sent while issue was closed.
This patch was merged into https://codereview.chromium.org/1336363002/ after the
Blink merge.

Powered by Google App Engine
This is Rietveld 408576698