Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2983)

Unified Diff: content/shell/browser/shell_permission_manager.cc

Issue 1342833002: permissions: handle request ids for permissions in permission manager (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Address review comment Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/shell/browser/shell_permission_manager.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/shell/browser/shell_permission_manager.cc
diff --git a/content/shell/browser/shell_permission_manager.cc b/content/shell/browser/shell_permission_manager.cc
index fffcfa560c3baf9dd26e7e39c876492fc2650b7e..da12bdb8f7e1a4b07f3bbaa81d33a4586db9b382 100644
--- a/content/shell/browser/shell_permission_manager.cc
+++ b/content/shell/browser/shell_permission_manager.cc
@@ -16,15 +16,15 @@ ShellPermissionManager::ShellPermissionManager()
ShellPermissionManager::~ShellPermissionManager() {
}
-void ShellPermissionManager::RequestPermission(
+int ShellPermissionManager::RequestPermission(
PermissionType permission,
RenderFrameHost* render_frame_host,
- int request_id,
const GURL& requesting_origin,
bool user_gesture,
const base::Callback<void(PermissionStatus)>& callback) {
callback.Run(permission == PermissionType::GEOLOCATION
? PERMISSION_STATUS_GRANTED : PERMISSION_STATUS_DENIED);
+ return kNoPendingOperation;
}
void ShellPermissionManager::CancelPermissionRequest(
@@ -58,7 +58,7 @@ int ShellPermissionManager::SubscribePermissionStatusChange(
const GURL& requesting_origin,
const GURL& embedding_origin,
const base::Callback<void(PermissionStatus)>& callback) {
- return -1;
+ return kNoPendingOperation;
}
void ShellPermissionManager::UnsubscribePermissionStatusChange(
« no previous file with comments | « content/shell/browser/shell_permission_manager.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698