Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8100)

Unified Diff: chromecast/browser/cast_permission_manager.cc

Issue 1342833002: permissions: handle request ids for permissions in permission manager (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Address review comment Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chromecast/browser/cast_permission_manager.h ('k') | content/browser/permissions/permission_service_impl.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chromecast/browser/cast_permission_manager.cc
diff --git a/chromecast/browser/cast_permission_manager.cc b/chromecast/browser/cast_permission_manager.cc
index 047a6ff5a909f0cf85b1b390a77f767a6ab4beae..eaa6b940a03cf7ee1f6b241f678d5e312e58e691 100644
--- a/chromecast/browser/cast_permission_manager.cc
+++ b/chromecast/browser/cast_permission_manager.cc
@@ -18,15 +18,15 @@ CastPermissionManager::CastPermissionManager()
CastPermissionManager::~CastPermissionManager() {
}
-void CastPermissionManager::RequestPermission(
+int CastPermissionManager::RequestPermission(
content::PermissionType permission,
content::RenderFrameHost* render_frame_host,
- int request_id,
const GURL& origin,
bool user_gesture,
const base::Callback<void(content::PermissionStatus)>& callback) {
LOG(INFO) << __FUNCTION__ << ": " << static_cast<int>(permission);
callback.Run(content::PermissionStatus::PERMISSION_STATUS_GRANTED);
+ return kNoPendingOperation;
}
void CastPermissionManager::CancelPermissionRequest(
@@ -61,7 +61,7 @@ int CastPermissionManager::SubscribePermissionStatusChange(
const GURL& requesting_origin,
const GURL& embedding_origin,
const base::Callback<void(content::PermissionStatus)>& callback) {
- return -1;
+ return kNoPendingOperation;
}
void CastPermissionManager::UnsubscribePermissionStatusChange(
« no previous file with comments | « chromecast/browser/cast_permission_manager.h ('k') | content/browser/permissions/permission_service_impl.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698