content/browser/permissions/permission_service_impl.h - Issue 1342833002: permissions: handle request ids for permissions in permission manager

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/permissions/permission_service_impl.h

Issue 1342833002: permissions: handle request ids for permissions in permission manager (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix test failures Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chromecast/browser/cast_permission_manager.cc ('K') | « content/browser/permissions/permission_service_context.cc ('k') | content/browser/permissions/permission_service_impl.cc » ('j') | content/browser/permissions/permission_service_impl.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/permissions/permission_service_impl.h

diff --git a/content/browser/permissions/permission_service_impl.h b/content/browser/permissions/permission_service_impl.h

index b83a6973f06692f8f8df961a9041465194f47abf..736f39703c64c22213c9a4c0a3a5927082178846 100644

--- a/content/browser/permissions/permission_service_impl.h

+++ b/content/browser/permissions/permission_service_impl.h

@@ -48,6 +48,7 @@ class PermissionServiceImpl : public PermissionService {

const PermissionStatusCallback& callback);

~PendingRequest();

+ int manager_id;

mlamouri (slow - plz ping) 2015/09/16 14:42:57 nit: rename to id to stay consistent with the subs

Lalit Maganti 2015/09/16 16:41:10 Done.

PermissionType permission;

GURL origin;

PermissionStatusCallback callback;