permissions: handle request ids for permissions in permission manager

android_webview/browser/aw_permission_manager.h

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef ANDROID_WEBVIEW_BROWSER_AW_PERMISSION_MANAGER_H_
 #define ANDROID_WEBVIEW_BROWSER_AW_PERMISSION_MANAGER_H_
 
 #include "base/callback_forward.h"
+#include "base/id_map.h"
 #include "base/macros.h"
 #include "base/memory/scoped_ptr.h"
+#include "base/memory/weak_ptr.h"
 #include "content/public/browser/permission_manager.h"
 
 namespace android_webview {
 
 class LastRequestResultCache;
 
 class AwPermissionManager : public content::PermissionManager {
  public:
   AwPermissionManager();
   ~AwPermissionManager() override;
 
   // PermissionManager implementation.
-  void RequestPermission(
+  int RequestPermission(
       content::PermissionType permission,
       content::RenderFrameHost* render_frame_host,
-      int request_id,
       const GURL& requesting_origin,
       bool user_gesture,
       const base::Callback<void(content::PermissionStatus)>& callback) override;
   void CancelPermissionRequest(content::PermissionType permission,
                                content::RenderFrameHost* render_frame_host,
                                int request_id,
                                const GURL& requesting_origin) override;
   void ResetPermission(content::PermissionType permission,
                        const GURL& requesting_origin,
                        const GURL& embedding_origin) override;
   content::PermissionStatus GetPermissionStatus(
       content::PermissionType permission,
       const GURL& requesting_origin,
       const GURL& embedding_origin) override;
   void RegisterPermissionUsage(content::PermissionType permission,
                                const GURL& requesting_origin,
                                const GURL& embedding_origin) override;
   int SubscribePermissionStatusChange(
       content::PermissionType permission,
       const GURL& requesting_origin,
       const GURL& embedding_origin,
       const base::Callback<void(content::PermissionStatus)>& callback) override;
   void UnsubscribePermissionStatusChange(int subscription_id) override;
 
  private:
+  class PendingRequest;
+  using PendingRequestsMap = IDMap<PendingRequest, IDMapOwnPointer>;
+
+  // The weak pointer to this is used to clean up any information which is
+  // stored in the pending request or result cache maps. However, the callback
+  // should be run regardless of whether the class is still alive so the method
+  // is static.
+  static void OnRequestResponse(

[mlamouri (slow - plz ping), 2015/09/28 14:15:04]

Move that to the .cc file?

[Lalit Maganti, 2015/09/28 16:07:01]

Done.

Apologies for missing your earlier comment michaelbai@

[Lalit Maganti, 2015/09/29 09:08:00]

I've had to switch this back because I utilize some private members of
AwPermissionManager so I need it to be a method of the class.

+      const base::WeakPtr<AwPermissionManager>& manager,
+      int request_id,
+      const base::Callback<void(content::PermissionStatus)>& callback,
+      bool allowed);
+
+  PendingRequestsMap pending_requests_;
   scoped_ptr<LastRequestResultCache> result_cache_;
 
+  base::WeakPtrFactory<AwPermissionManager> weak_ptr_factory_;
+
   DISALLOW_COPY_AND_ASSIGN(AwPermissionManager);
 };
 
 } // namespace android_webview
 
 #endif // ANDROID_WEBVIEW_BROWSER_AW_PERMISSION_MANAGER_H_