Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(480)

Issue 1342803004: Add information on how to contribute to the README (Closed)

Created:
5 years, 3 months ago by Michael Hablich
Modified:
5 years, 3 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[Docs] Add information on how to contribute to the README I noticed after reading a few GitHub comments that the information about contributing to V8 is hard to find. I think it makes sense to add this information to the README. NOTRY=true R=jochen@chromium.org, seththompson@chromium.org LOG=N Committed: https://crrev.com/8d77f788e7b626b9fda633e600405f720bfad8f7 Cr-Commit-Position: refs/heads/master@{#30730}

Patch Set 1 #

Messages

Total messages: 7 (2 generated)
Michael Hablich
PTAL
5 years, 3 months ago (2015-09-14 18:15:39 UTC) #1
jochen (gone - plz use gerrit)
lgtm
5 years, 3 months ago (2015-09-15 07:38:05 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1342803004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1342803004/1
5 years, 3 months ago (2015-09-15 07:51:50 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 3 months ago (2015-09-15 07:53:04 UTC) #6
commit-bot: I haz the power
5 years, 3 months ago (2015-09-15 07:53:20 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/8d77f788e7b626b9fda633e600405f720bfad8f7
Cr-Commit-Position: refs/heads/master@{#30730}

Powered by Google App Engine
This is Rietveld 408576698