[LayoutTests] Add a new requestIdleCallback layout test which checks idle period behavior.

[LayoutTests] Add a new requestIdleCallback layout test which checks idle period behavior.

BUG=514651
Committed: https://crrev.com/d7a32e7249149a86a3db32f0cdb98ceb7a44ad5a
git-svn-id: svn://svn.chromium.org/blink/trunk@202209 bbb929c8-8fbe-4397-9dbb-9b2b20218538

[rmcilroy, 2015-09-14 15:21:18]

The CQ bit was checked by rmcilroy@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-09-14 15:21:28]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1342803002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1342803002/1

[rmcilroy, 2015-09-14 15:21:46]

rmcilroy@chromium.org changed reviewers:
+ skyostil@chromium.org

[rmcilroy, 2015-09-14 15:21:46]

Sami, could you take a look please? Thanks.

[Sami, 2015-09-14 15:55:38]

Looks great, lgtm.

Do you need to check in expectations for these tests or does the rebaseline bot
do that for us?

https://codereview.chromium.org/1342803002/diff/1/LayoutTests/virtual/threade...
File LayoutTests/virtual/threaded/fast/idle-callback/idle_periods.html (right):

https://codereview.chromium.org/1342803002/diff/1/LayoutTests/virtual/threade...
LayoutTests/virtual/threaded/fast/idle-callback/idle_periods.html:11: // Check
whether separate calls to requestIdleCallbacks can run in the same
nit: This description is a little vague in the sense that it's not clear whether
yes or no is the right answer to this check.

https://codereview.chromium.org/1342803002/diff/1/LayoutTests/virtual/threade...
LayoutTests/virtual/threaded/fast/idle-callback/idle_periods.html:26: if
(callback_1_deadline != undefined) {
I'm wondering if we should do this in a loop until we get enough idle time.
Worth the trouble?

[commit-bot: I haz the power, 2015-09-14 16:11:42]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-09-14 16:11:42]

Dry run: This issue passed the CQ dry run.

[rmcilroy, 2015-09-14 16:24:33]

> Do you need to check in expectations for these tests or does the rebaseline
bot
> do that for us?

No expectations necessary for a testrunner based test (the expectation is just
that all the asserts pass).

https://codereview.chromium.org/1342803002/diff/1/LayoutTests/virtual/threade...
File LayoutTests/virtual/threaded/fast/idle-callback/idle_periods.html (right):

https://codereview.chromium.org/1342803002/diff/1/LayoutTests/virtual/threade...
LayoutTests/virtual/threaded/fast/idle-callback/idle_periods.html:11: // Check
whether separate calls to requestIdleCallbacks can run in the same
On 2015/09/14 15:55:37, Sami wrote:
> nit: This description is a little vague in the sense that it's not clear
whether
> yes or no is the right answer to this check.

Done.

https://codereview.chromium.org/1342803002/diff/1/LayoutTests/virtual/threade...
LayoutTests/virtual/threaded/fast/idle-callback/idle_periods.html:26: if
(callback_1_deadline != undefined) {
On 2015/09/14 15:55:37, Sami wrote:
> I'm wondering if we should do this in a loop until we get enough idle time.
> Worth the trouble?

Added a loop if we weren't able to do the check. Does this work?

[rmcilroy, 2015-09-14 16:24:37]

The CQ bit was checked by rmcilroy@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-09-14 16:24:55]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1342803002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1342803002/20001

[Sami, 2015-09-14 16:46:36]

Thanks, still lgtm!

[commit-bot: I haz the power, 2015-09-14 17:22:44]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-09-14 17:22:45]

Dry run: This issue passed the CQ dry run.

[rmcilroy, 2015-09-14 17:30:58]

The CQ bit was checked by rmcilroy@chromium.org

[commit-bot: I haz the power, 2015-09-14 17:31:30]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1342803002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1342803002/20001

[commit-bot: I haz the power, 2015-09-14 17:41:06]

Committed patchset #2 (id:20001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=202209

[commit-bot: I haz the power, 2015-09-23 12:33:51]

Patchset 2 (id:??) landed as
https://crrev.com/d7a32e7249149a86a3db32f0cdb98ceb7a44ad5a