[Spellcheck] Record the number of words in the custom dictionary when the custom dictionary is load…

[Spellcheck] Record the number of words in the custom dictionary when the custom dictionary is loaded.

This was removed during the refactor and needs to be put back in.

BUG=226249
TEST=SpellcheckCustomDictionaryTest::RecordSizeStatsCorrectly


Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=192683

[please use gerrit instead, 2013-04-04 00:31:55]

LGTM with nits.

https://codereview.chromium.org/13428008/diff/1005/chrome/browser/spellchecke...
File chrome/browser/spellchecker/spellcheck_custom_dictionary_unittest.cc
(right):

https://codereview.chromium.org/13428008/diff/1005/chrome/browser/spellchecke...
chrome/browser/spellchecker/spellcheck_custom_dictionary_unittest.cc:73:
base::StatisticsRecorder::Initialize();
Nit: No need for "base::" here since you're "using base::StatisticsRecorder"
above.

https://codereview.chromium.org/13428008/diff/1005/chrome/browser/spellchecke...
chrome/browser/spellchecker/spellcheck_custom_dictionary_unittest.cc:74:
metrics_.reset(new SpellCheckHostMetrics);
No need for an instance of SpellcheckHostMetrics object, since you've made
RecordCustomWordCountStats static. (I think that
spellcheck_host_metrics_unittest.cc also calls RecordCustomWordCountStats
dynamically. Please update that test to call the method statically.)

https://codereview.chromium.org/13428008/diff/1005/chrome/browser/spellchecke...
chrome/browser/spellchecker/spellcheck_custom_dictionary_unittest.cc:120:
scoped_ptr<SpellCheckHostMetrics> metrics_;
Ditto.

https://codereview.chromium.org/13428008/diff/1005/chrome/browser/spellchecke...
chrome/browser/spellchecker/spellcheck_custom_dictionary_unittest.cc:1091:
metrics_->RecordCustomWordCountStats(123);
Ditto.

[rpetterson, 2013-04-04 20:24:37]

https://codereview.chromium.org/13428008/diff/1005/chrome/browser/spellchecke...
File chrome/browser/spellchecker/spellcheck_custom_dictionary_unittest.cc
(right):

https://codereview.chromium.org/13428008/diff/1005/chrome/browser/spellchecke...
chrome/browser/spellchecker/spellcheck_custom_dictionary_unittest.cc:73:
base::StatisticsRecorder::Initialize();
On 2013/04/04 00:31:55, Rouslan Solomakhin wrote:
> Nit: No need for "base::" here since you're "using base::StatisticsRecorder"
> above.

Done.

https://codereview.chromium.org/13428008/diff/1005/chrome/browser/spellchecke...
chrome/browser/spellchecker/spellcheck_custom_dictionary_unittest.cc:74:
metrics_.reset(new SpellCheckHostMetrics);
On 2013/04/04 00:31:55, Rouslan Solomakhin wrote:
> No need for an instance of SpellcheckHostMetrics object, since you've made
> RecordCustomWordCountStats static. (I think that
> spellcheck_host_metrics_unittest.cc also calls RecordCustomWordCountStats
> dynamically. Please update that test to call the method statically.)

Done.

https://codereview.chromium.org/13428008/diff/1005/chrome/browser/spellchecke...
chrome/browser/spellchecker/spellcheck_custom_dictionary_unittest.cc:120:
scoped_ptr<SpellCheckHostMetrics> metrics_;
On 2013/04/04 00:31:55, Rouslan Solomakhin wrote:
> Ditto.

Done.

https://codereview.chromium.org/13428008/diff/1005/chrome/browser/spellchecke...
chrome/browser/spellchecker/spellcheck_custom_dictionary_unittest.cc:1091:
metrics_->RecordCustomWordCountStats(123);
On 2013/04/04 00:31:55, Rouslan Solomakhin wrote:
> Ditto.

Done.

[commit-bot: I haz the power, 2013-04-05 20:58:17]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/rlp@chromium.org/13428008/6001

[commit-bot: I haz the power, 2013-04-06 01:16:44]

Change committed as 192683