Add GrDrawTarget::copySurface.

Add GrDrawTarget::copySurface.
Committed: https://code.google.com/p/skia/source/detail?r=8510

[robertphillips, 2013-04-03 12:21:27]

lgtm + 1 suggestion & 1 question

https://codereview.chromium.org/13428004/diff/8001/src/gpu/GrDrawTarget.cpp
File src/gpu/GrDrawTarget.cpp (right):

https://codereview.chromium.org/13428004/diff/8001/src/gpu/GrDrawTarget.cpp#n...
src/gpu/GrDrawTarget.cpp:811: const SkIPoint& dstPoint) {
asserts here r.e. srcRect & dstPoint being clipped to src & dst & non-empty

https://codereview.chromium.org/13428004/diff/8001/src/gpu/GrDrawTarget.h
File src/gpu/GrDrawTarget.h (right):

https://codereview.chromium.org/13428004/diff/8001/src/gpu/GrDrawTarget.h#new...
src/gpu/GrDrawTarget.h:420: */
can src be "const GrSurface& src"?

[bsalomon, 2013-04-03 12:51:52]

https://codereview.chromium.org/13428004/diff/8001/src/gpu/GrDrawTarget.cpp
File src/gpu/GrDrawTarget.cpp (right):

https://codereview.chromium.org/13428004/diff/8001/src/gpu/GrDrawTarget.cpp#n...
src/gpu/GrDrawTarget.cpp:811: const SkIPoint& dstPoint) {
On 2013/04/03 12:21:27, robertphillips wrote:
> asserts here r.e. srcRect & dstPoint being clipped to src & dst & non-empty

Will add.

https://codereview.chromium.org/13428004/diff/8001/src/gpu/GrDrawTarget.h
File src/gpu/GrDrawTarget.h (right):

https://codereview.chromium.org/13428004/diff/8001/src/gpu/GrDrawTarget.h#new...
src/gpu/GrDrawTarget.h:420: */
On 2013/04/03 12:21:27, robertphillips wrote:
> can src be "const GrSurface& src"?

As for const, you can't do much with const GrResources. You can't draw from a
const GrTexture, for example.

As for ref, I think it should be a ptr because it is ref counted and we will
internally take refs to the texture.

[robertphillips, 2013-04-03 13:01:29]

https://codereview.chromium.org/13428004/diff/8001/src/gpu/GrDrawTarget.h
File src/gpu/GrDrawTarget.h (right):

https://codereview.chromium.org/13428004/diff/8001/src/gpu/GrDrawTarget.h#new...
src/gpu/GrDrawTarget.h:420: */
That's what I thought but I figured it wouldn't hurt to ask.

[bsalomon, 2013-04-03 14:41:58]

Add GrDrawTarget::copySurface.

[bsalomon, 2013-04-03 14:56:44]

Committed patchset #5 manually as r8510 (presubmit successful).