Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(302)

Side by Side Diff: chrome/browser/ui/toolbar/recent_tabs_sub_menu_model.cc

Issue 1342743002: Remove Profile and HostDesktopType dependencies from core TabRestore code (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix Mac Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2012 The Chromium Authors. All rights reserved. 1 // Copyright 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/ui/toolbar/recent_tabs_sub_menu_model.h" 5 #include "chrome/browser/ui/toolbar/recent_tabs_sub_menu_model.h"
6 6
7 #include "base/bind.h" 7 #include "base/bind.h"
8 #include "base/metrics/histogram.h" 8 #include "base/metrics/histogram.h"
9 #include "base/prefs/scoped_user_pref_update.h" 9 #include "base/prefs/scoped_user_pref_update.h"
10 #include "base/strings/string_number_conversions.h" 10 #include "base/strings/string_number_conversions.h"
11 #include "base/strings/utf_string_conversions.h" 11 #include "base/strings/utf_string_conversions.h"
12 #include "chrome/app/chrome_command_ids.h" 12 #include "chrome/app/chrome_command_ids.h"
13 #include "chrome/browser/favicon/favicon_service_factory.h" 13 #include "chrome/browser/favicon/favicon_service_factory.h"
14 #include "chrome/browser/profiles/profile.h" 14 #include "chrome/browser/profiles/profile.h"
15 #include "chrome/browser/search/search.h" 15 #include "chrome/browser/search/search.h"
16 #include "chrome/browser/sessions/session_restore.h" 16 #include "chrome/browser/sessions/session_restore.h"
17 #include "chrome/browser/sessions/tab_restore_service.h" 17 #include "chrome/browser/sessions/tab_restore_service.h"
18 #include "chrome/browser/sessions/tab_restore_service_delegate.h"
19 #include "chrome/browser/sessions/tab_restore_service_factory.h" 18 #include "chrome/browser/sessions/tab_restore_service_factory.h"
20 #include "chrome/browser/sync/profile_sync_service.h" 19 #include "chrome/browser/sync/profile_sync_service.h"
21 #include "chrome/browser/sync/profile_sync_service_factory.h" 20 #include "chrome/browser/sync/profile_sync_service_factory.h"
22 #include "chrome/browser/ui/browser.h" 21 #include "chrome/browser/ui/browser.h"
23 #include "chrome/browser/ui/browser_commands.h" 22 #include "chrome/browser/ui/browser_commands.h"
23 #include "chrome/browser/ui/browser_tab_restore_service_delegate.h"
24 #include "chrome/browser/ui/tabs/tab_strip_model.h" 24 #include "chrome/browser/ui/tabs/tab_strip_model.h"
25 #include "chrome/browser/ui/toolbar/wrench_menu_model.h" 25 #include "chrome/browser/ui/toolbar/wrench_menu_model.h"
26 #include "chrome/grit/generated_resources.h" 26 #include "chrome/grit/generated_resources.h"
27 #include "components/favicon_base/favicon_types.h" 27 #include "components/favicon_base/favicon_types.h"
28 #include "components/sync_driver/glue/synced_session.h" 28 #include "components/sync_driver/glue/synced_session.h"
29 #include "components/sync_driver/open_tabs_ui_delegate.h" 29 #include "components/sync_driver/open_tabs_ui_delegate.h"
30 #include "content/public/browser/user_metrics.h" 30 #include "content/public/browser/user_metrics.h"
31 #include "grit/browser_resources.h" 31 #include "grit/browser_resources.h"
32 #include "grit/theme_resources.h" 32 #include "grit/theme_resources.h"
33 #include "ui/base/accelerators/accelerator.h" 33 #include "ui/base/accelerators/accelerator.h"
(...skipping 252 matching lines...) Expand 10 before | Expand all | Expand 10 after
286 DCHECK(!IsDeviceNameCommandId(command_id)); 286 DCHECK(!IsDeviceNameCommandId(command_id));
287 287
288 WindowOpenDisposition disposition = 288 WindowOpenDisposition disposition =
289 ui::DispositionFromEventFlags(event_flags); 289 ui::DispositionFromEventFlags(event_flags);
290 if (disposition == CURRENT_TAB) // Force to open a new foreground tab. 290 if (disposition == CURRENT_TAB) // Force to open a new foreground tab.
291 disposition = NEW_FOREGROUND_TAB; 291 disposition = NEW_FOREGROUND_TAB;
292 292
293 TabRestoreService* service = 293 TabRestoreService* service =
294 TabRestoreServiceFactory::GetForProfile(browser_->profile()); 294 TabRestoreServiceFactory::GetForProfile(browser_->profile());
295 TabRestoreServiceDelegate* delegate = 295 TabRestoreServiceDelegate* delegate =
296 TabRestoreServiceDelegate::FindDelegateForWebContents( 296 BrowserTabRestoreServiceDelegate::FindDelegateForWebContents(
297 browser_->tab_strip_model()->GetActiveWebContents()); 297 browser_->tab_strip_model()->GetActiveWebContents());
298 if (IsTabModelCommandId(command_id)) { 298 if (IsTabModelCommandId(command_id)) {
299 TabNavigationItems* tab_items = NULL; 299 TabNavigationItems* tab_items = NULL;
300 int tab_items_idx = CommandIdToTabVectorIndex(command_id, &tab_items); 300 int tab_items_idx = CommandIdToTabVectorIndex(command_id, &tab_items);
301 const TabNavigationItem& item = (*tab_items)[tab_items_idx]; 301 const TabNavigationItem& item = (*tab_items)[tab_items_idx];
302 DCHECK(item.tab_id > -1 && item.url.is_valid()); 302 DCHECK(item.tab_id > -1 && item.url.is_valid());
303 303
304 if (item.session_tag.empty()) { // Restore tab of local session. 304 if (item.session_tag.empty()) { // Restore tab of local session.
305 if (service && delegate) { 305 if (service && delegate) {
306 content::RecordAction( 306 content::RecordAction(
(...skipping 412 matching lines...) Expand 10 before | Expand all | Expand 10 after
719 719
720 ui::MenuModelDelegate* menu_model_delegate = GetMenuModelDelegate(); 720 ui::MenuModelDelegate* menu_model_delegate = GetMenuModelDelegate();
721 if (menu_model_delegate) 721 if (menu_model_delegate)
722 menu_model_delegate->OnMenuStructureChanged(); 722 menu_model_delegate->OnMenuStructureChanged();
723 } 723 }
724 724
725 void RecentTabsSubMenuModel::TabRestoreServiceDestroyed( 725 void RecentTabsSubMenuModel::TabRestoreServiceDestroyed(
726 TabRestoreService* service) { 726 TabRestoreService* service) {
727 TabRestoreServiceChanged(service); 727 TabRestoreServiceChanged(service);
728 } 728 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698