[Android] Extract signing+zipaligning to python

build/android/gyp/finalize_apk.py

Index: build/android/gyp/finalize_apk.py
diff --git a/build/android/gyp/finalize_apk.py b/build/android/gyp/finalize_apk.py
new file mode 100755
index 0000000000000000000000000000000000000000..5294a20a3d15038dee8a2ca4ea072466d8277492
--- /dev/null
+++ b/build/android/gyp/finalize_apk.py
@@ -0,0 +1,69 @@
+#!/usr/bin/env python
+#
+# Copyright 2013 The Chromium Authors. All rights reserved.
+# Use of this source code is governed by a BSD-style license that can be
+# found in the LICENSE file.
+"""Signs and zipaligns APK.
+
+"""
+
+import optparse
+import os
+import shutil
+import sys
+
+from util import build_utils
+
+def SignApk(keystore_path, unsigned_path, signed_path):
+  intermediate_path = unsigned_path + '.copy'

[shashi, 2013/04/08 22:39:04]

why the extra copy? Can we run it on unsigned path itself?

[cjhopman, 2013/04/09 01:58:19]

unsigned_path is an input to this action and we shouldn't be modifying our
inputs.

we could copy unsigned_path to signed_path and then sign it in-place there, but
that seems wrong in the case where signing fails. i.e. the output(+its
timestamp) will have been updated.

+  shutil.copy(unsigned_path, intermediate_path)
+  sign_cmd = [
+      'jarsigner',
+      '-sigalg', 'MD5withRSA',
+      '-digestalg', 'SHA1',
+      '-keystore', keystore_path,
+      '-storepass', 'chromium',
+      intermediate_path,
+      'chromiumdebugkey',
+    ]
+  build_utils.CheckCallDie(sign_cmd)
+  shutil.move(intermediate_path, signed_path)
+
+
+def AlignApk(android_sdk_root, unaligned_path, final_path):
+  align_cmd = [
+      os.path.join(android_sdk_root, 'tools', 'zipalign'),
+      '-f', '4',

[shashi, 2013/04/08 22:39:04]

Why is it 4? (32 bit?) a clarifying comment will make it easier to understand.

[cjhopman, 2013/04/09 01:58:19]

Done.

+      unaligned_path,
+      final_path,

[shashi, 2013/04/08 22:39:04]

Do we need a verbosity option here for debugging?

[cjhopman, 2013/04/09 01:58:19]

This is already more verbose than in ant (i.e. it's output is printed rather
than suppressed).

+      ]
+  build_utils.CheckCallDie(align_cmd)
+
+
+def main(argv):
+  parser = optparse.OptionParser()
+
+  parser.add_option('--android-sdk-root', help='Android sdk root directory.')
+  parser.add_option('--unsigned-apk-path', help='Path to input unsigned APK.')
+  parser.add_option('--final-apk-path',
+      help='Path to output signed and aligned APK.')
+  parser.add_option('--keystore-path', help='Path to keystore for signing.')
+  parser.add_option('--stamp', help='Path to touch on success.')
+
+  # TODO(newt): remove this once http://crbug.com/177552 is fixed in ninja.
+  parser.add_option('--ignore', help='Ignored.')
+
+  options, _ = parser.parse_args()
+
+  signed_apk_path = options.unsigned_apk_path + '.signed.apk'
+  SignApk(options.keystore_path, options.unsigned_apk_path, signed_apk_path)
+  AlignApk(options.android_sdk_root, signed_apk_path, options.final_apk_path)
+
+  if options.stamp:
+    build_utils.Touch(options.stamp)
+
+
+if __name__ == '__main__':
+  sys.exit(main(sys.argv))
+
+