Issue 13427004: re-land r8514 without breaking 32-bit Mac compilers

Issue 13427004: re-land r8514 without breaking 32-bit Mac compilers (Closed)

Created:
7 years, 8 months ago by epoger

Modified:
7 years, 8 months ago

Reviewers:

CC:
skia-review_googlegroups.com

Base URL:
http://skia.googlecode.com/svn/trunk/

Visibility:
Public.

More Reviews

Description

re-land r8514 without breaking 32-bit Mac compilers Committed: https://code.google.com/p/skia/source/detail?r=8518

Patch Set 2 : fix #

Total comments: 1

Created: 7 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+291 lines, -76 lines)			Patch
M	gm/gm_error.h	View	1	3 chunks	+31 lines, -2 lines	1 comment	Download
M	gm/gmmain.cpp	View		15 chunks	+180 lines, -62 lines	0 comments	Download
M	gm/tests/outputs/compared-against-different-pixels-images/output-expected/stderr	View		1 chunk	+0 lines, -2 lines	0 comments	Download
M	gm/tests/outputs/compared-against-different-pixels-images/output-expected/stdout	View		1 chunk	+10 lines, -1 line	0 comments	Download
M	gm/tests/outputs/compared-against-different-pixels-json/output-expected/stderr	View		1 chunk	+0 lines, -2 lines	0 comments	Download
M	gm/tests/outputs/compared-against-different-pixels-json/output-expected/stdout	View		1 chunk	+10 lines, -1 line	0 comments	Download
M	gm/tests/outputs/compared-against-empty-dir/output-expected/stdout	View		1 chunk	+10 lines, -1 line	0 comments	Download
M	gm/tests/outputs/compared-against-identical-bytes-images/output-expected/stdout	View		1 chunk	+10 lines, -1 line	0 comments	Download
M	gm/tests/outputs/compared-against-identical-bytes-json/output-expected/stdout	View		1 chunk	+10 lines, -1 line	0 comments	Download
M	gm/tests/outputs/compared-against-identical-pixels-images/output-expected/stdout	View		1 chunk	+10 lines, -1 line	0 comments	Download
M	gm/tests/outputs/compared-against-identical-pixels-json/output-expected/stdout	View		1 chunk	+10 lines, -1 line	0 comments	Download
M	gm/tests/outputs/no-readpath/output-expected/stdout	View		1 chunk	+10 lines, -1 line	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

epoger

patchset 1 just reapplies https://code.google.com/p/skia/source/detail?r=8514 without modification

7 years, 8 months ago (2013-04-03 17:45:58 UTC) #1

epoger

https://codereview.chromium.org/13427004/diff/5001/gm/gm_error.h File gm/gm_error.h (right): https://codereview.chromium.org/13427004/diff/5001/gm/gm_error.h#newcode38 gm/gm_error.h:38: static const char *getErrorTypeName(ErrorType type) { here's the fix...

7 years, 8 months ago (2013-04-03 18:00:06 UTC) #2

epoger

7 years, 8 months ago (2013-04-03 18:00:51 UTC) #3

Message was sent while issue was closed.

Committed patchset #2 manually as r8518 (presubmit successful).

Expand Messages | Collapse Messages