Implement inline signin with iframe

chrome/browser/ui/webui/signin/inline_login_ui.cc

Index: chrome/browser/ui/webui/signin/inline_login_ui.cc
diff --git a/chrome/browser/ui/webui/signin/inline_login_ui.cc b/chrome/browser/ui/webui/signin/inline_login_ui.cc
index 4748c0418a079a73404adc0502c37a5927b072bf..17079533e2b4c6e08696fca49eb0aeafe25eb088 100644
--- a/chrome/browser/ui/webui/signin/inline_login_ui.cc
+++ b/chrome/browser/ui/webui/signin/inline_login_ui.cc
@@ -22,6 +22,7 @@ namespace {
 content::WebUIDataSource* CreateWebUIDataSource() {
   content::WebUIDataSource* source =
         content::WebUIDataSource::Create(chrome::kChromeUIChromeSigninHost);
+  source->OverrideContentSecurityPolicyFrameSrc("frame-src chrome-extension:;");
   source->SetUseJsonJSFormatV2();
   source->SetJsonPath("strings.js");
 
@@ -45,10 +46,6 @@ InlineLoginUI::InlineLoginUI(content::WebUI* web_ui)
   web_ui->AddMessageHandler(new chromeos::InlineLoginHandlerChromeOS());
 #else
   web_ui->AddMessageHandler(new InlineLoginHandlerImpl());
-  // Required for intercepting extension function calls when the page is loaded
-  // in a bubble (not a full tab, thus tab helpers are not registered
-  // automatically).
-  extensions::TabHelper::CreateForWebContents(web_ui->GetWebContents());

[guohui, 2014/02/11 22:29:57]

To fix the embedded signin flow, instead of creating the extension tab helper in
profile_chooser_view, you might want to just revert the changes here. Both do
the same thing, except the code here makes sure regardless of where the inline
signin is triggered, it always creates an extension tab helper.

[xiyuan, 2014/02/11 22:39:55]

We need "ExtensionWebContentsObserver". But this looks like a better place than
profile_chooser_view

[guohui, 2014/02/11 23:22:43]

I had similar issue before when implementing the embedded flow with webview, and
fixed it by adding the lines here. Thought it would apply to the iframe approach
as well.

@Roger, if these lines do not work as expected, then you might want to replace
the TabHelper with ExtensionWebContentsObserver as XIyuan suggested.

[Roger Tawa OOO till Jul 10th, 2014/02/12 03:07:12]

Implemented Xiyuan's suggestion here.

 #endif
 }