Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(665)

Unified Diff: chrome/browser/resources/gaia_auth/desktop_injected.js

Issue 134263005: Implement inline signin with iframe (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: fix for various iframe bugs Created 6 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/resources/gaia_auth/desktop_injected.js
diff --git a/chrome/browser/resources/gaia_auth/inline_injected.js b/chrome/browser/resources/gaia_auth/desktop_injected.js
similarity index 75%
rename from chrome/browser/resources/gaia_auth/inline_injected.js
rename to chrome/browser/resources/gaia_auth/desktop_injected.js
index b0b847381605721df5b9cdd51002df55a5a6a6bd..da7a78461fa2174d0be4eef51cacddcfa8afd6b0 100644
--- a/chrome/browser/resources/gaia_auth/inline_injected.js
+++ b/chrome/browser/resources/gaia_auth/desktop_injected.js
@@ -11,23 +11,14 @@
*/
(function() {
- var extWindow;
-
var $ = function(id) { return document.getElementById(id); };
- var gaiaLoginForm = $('gaia_loginform');
- var onMessage = function(e) {
- extWindow = e.source;
- };
- window.addEventListener('message', onMessage);
+ var gaiaLoginForm = $('gaia_loginform');
+ if (!gaiaLoginForm) {
+ return;
+ }
var onLoginSubmit = function(e) {
- if (!extWindow) {
- console.log('ERROR: no initial message received from the gaia ext');
- e.preventDefault();
- return;
- }
-
var checkboxElement = $('advanced-box');
var chooseWhatToSync = checkboxElement && checkboxElement.checked;
var msg = {method: 'attemptLogin',
@@ -36,8 +27,8 @@
attemptToken: new Date().getTime(),
chooseWhatToSync: chooseWhatToSync};
- extWindow.postMessage(msg, 'chrome://chrome-signin');
- console.log('Credentials sent');
+ window.parent.postMessage(
+ msg, 'chrome-extension://mfffpogegjflfpflabcdkioaeobkgjik');
return;
};
« no previous file with comments | « chrome/browser/resources/gaia_auth/background.js ('k') | chrome/browser/resources/gaia_auth/inline_injected.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698