Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(93)

Unified Diff: chrome/browser/chrome_content_browser_client.cc

Issue 134263005: Implement inline signin with iframe (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: fix for various iframe bugs Created 6 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/chrome_content_browser_client.cc
diff --git a/chrome/browser/chrome_content_browser_client.cc b/chrome/browser/chrome_content_browser_client.cc
index 3fe2b785c8fb8db6616a51b8a507e54467e8d86d..8872d1ec54eb58d17bff4430598ba62f1f45a169 100644
--- a/chrome/browser/chrome_content_browser_client.cc
+++ b/chrome/browser/chrome_content_browser_client.cc
@@ -743,8 +743,13 @@ std::string ChromeContentBrowserClient::GetStoragePartitionIdForSite(
// The partition ID for webview guest processes is the string value of its
// SiteInstance URL - "chrome-guest://app_id/persist?partition".
- if (site.SchemeIs(content::kGuestScheme))
+ if (site.SchemeIs(content::kGuestScheme)) {
partition_id = site.spec();
+ } else if (site.GetOrigin().spec() == kChromeUIChromeSigninURL) {
+ // Chrome signin page has an embedded iframe of extension and web content,
+ // thus it must be isolated from other webUI pages.
+ partition_id = site.GetOrigin().spec();
+ }
DCHECK(IsValidStoragePartitionId(browser_context, partition_id));
return partition_id;
@@ -808,6 +813,10 @@ void ChromeContentBrowserClient::GetStoragePartitionConfigForSite(
*in_memory = false;
partition_name->clear();
}
+ } else if (site.GetOrigin().spec() == kChromeUIChromeSigninURL) {
+ // Chrome signin page has an embedded iframe of extension and web content,
+ // thus it must be isolated from other webUI pages.
+ *partition_domain = chrome::kChromeUIChromeSigninHost;
}
// Assert that if |can_be_default| is false, the code above must have found a
« no previous file with comments | « chrome/browser/browser_resources.grd ('k') | chrome/browser/extensions/signin/gaia_auth_extension_loader.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698