Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(950)

Unified Diff: net/http/http_network_layer.h

Issue 1342613002: Revert of Remove reference counting from HttpNetworkSession. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/http/http_cache.cc ('k') | net/http/http_network_layer.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/http/http_network_layer.h
diff --git a/net/http/http_network_layer.h b/net/http/http_network_layer.h
index 89ff8eb73d77efcb26b62b8242ff8430d53a4960..23b4e1eb2dba45c065fed2f38d9c6f9784c88f60 100644
--- a/net/http/http_network_layer.h
+++ b/net/http/http_network_layer.h
@@ -26,10 +26,17 @@
NON_EXPORTED_BASE(public base::NonThreadSafe) {
public:
// Construct a HttpNetworkLayer with an existing HttpNetworkSession which
- // contains a valid ProxyService. The HttpNetworkLayer must be destroyed
- // before |session|.
+ // contains a valid ProxyService.
explicit HttpNetworkLayer(HttpNetworkSession* session);
~HttpNetworkLayer() override;
+
+ // Create a transaction factory that instantiate a network layer over an
+ // existing network session. Network session contains some valuable
+ // information (e.g. authentication data) that we want to share across
+ // multiple network layers. This method exposes the implementation details
+ // of a network layer, use this method with an existing network layer only
+ // when network session is shared.
+ static HttpTransactionFactory* CreateFactory(HttpNetworkSession* session);
// HttpTransactionFactory methods:
int CreateTransaction(RequestPriority priority,
@@ -42,7 +49,7 @@
void OnResume() override;
private:
- HttpNetworkSession* const session_;
+ const scoped_refptr<HttpNetworkSession> session_;
bool suspended_;
DISALLOW_COPY_AND_ASSIGN(HttpNetworkLayer);
« no previous file with comments | « net/http/http_cache.cc ('k') | net/http/http_network_layer.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698