Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(54)

Unified Diff: net/http/http_network_session.h

Issue 1342613002: Revert of Remove reference counting from HttpNetworkSession. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/http/http_network_layer_unittest.cc ('k') | net/http/http_network_session_peer.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/http/http_network_session.h
diff --git a/net/http/http_network_session.h b/net/http/http_network_session.h
index 73709334d40b50cb2511a7b14398b6d73df070eb..7ccba8607a63255d7210f847b114b85615ce2110 100644
--- a/net/http/http_network_session.h
+++ b/net/http/http_network_session.h
@@ -57,7 +57,8 @@
// This class holds session objects used by HttpNetworkTransaction objects.
class NET_EXPORT HttpNetworkSession
- : NON_EXPORTED_BASE(public base::NonThreadSafe) {
+ : public base::RefCounted<HttpNetworkSession>,
+ NON_EXPORTED_BASE(public base::NonThreadSafe) {
public:
struct NET_EXPORT Params {
Params();
@@ -139,7 +140,6 @@
};
explicit HttpNetworkSession(const Params& params);
- ~HttpNetworkSession();
HttpAuthCache* http_auth_cache() { return &http_auth_cache_; }
SSLClientAuthCache* ssl_client_auth_cache() {
@@ -212,7 +212,10 @@
bool HasSpdyExclusion(HostPortPair host_port_pair) const;
private:
+ friend class base::RefCounted<HttpNetworkSession>;
friend class HttpNetworkSessionPeer;
+
+ ~HttpNetworkSession();
ClientSocketPoolManager* GetSocketPoolManager(SocketPoolType pool_type);
« no previous file with comments | « net/http/http_network_layer_unittest.cc ('k') | net/http/http_network_session_peer.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698