Clean up logging in MB.

Clean up logging in MB.

By default, the bots run `mb -v`, which dumps a lot of output,
especially when generating isolates for GN. This patch cleans
up a lot of the output so that we log a minimal subset most of the
time and more on errors (but -v will still dump everything).

In the common (non-error) case, this means that we'll get only 1-2
lines of output per MB invocation.

In addition, this patch removes the --quiet flag (which was never used)
and the RunGNIsolate() function, which was never called, and fixes
a minor but annoying issue where we would list the same dependency
multiple times in the analyze results.

R=thakis@chromium.org
BUG=

Committed: https://crrev.com/e0547cd084409dd5f6c336a2babb47ca28a66d1f
Cr-Commit-Position: refs/heads/master@{#348806}

[Dirk Pranke, 2015-09-11 23:16:31]

Patchset #1 (id:1) has been deleted

[Dirk Pranke, 2015-09-11 23:16:37]

Patchset #1 (id:20001) has been deleted

[Dirk Pranke, 2015-09-11 23:22:15]

Patchset #1 (id:40001) has been deleted

[Dirk Pranke, 2015-09-11 23:27:52]

With this change and a change to the recipes to not pass -v, things should be
substantially quieter.

https://codereview.chromium.org/1342563002/diff/80001/tools/mb/mb.py
File tools/mb/mb.py (left):

https://codereview.chromium.org/1342563002/diff/80001/tools/mb/mb.py#oldcode727
tools/mb/mb.py:727: if not ret and self.args.verbose:
We don't really care about the return value at this point, so the check was
unnecessary.

https://codereview.chromium.org/1342563002/diff/80001/tools/mb/mb.py
File tools/mb/mb.py (right):

https://codereview.chromium.org/1342563002/diff/80001/tools/mb/mb.py#newcode666
tools/mb/mb.py:666: 'build_targets': sorted(set(matching_targets)),
This fixes a minor annoyance where if multiple targets had a dependency on, say
'base', we would list base multiple times in the analyze results.

[Dirk Pranke, 2015-09-11 23:28:27]

Patchset #1 (id:60001) has been deleted

[Nico, 2015-09-11 23:31:16]

(somewhat stampy) lgtm, thanks!

https://codereview.chromium.org/1342563002/diff/80001/tools/mb/mb.py
File tools/mb/mb.py (right):

https://codereview.chromium.org/1342563002/diff/80001/tools/mb/mb.py#newcode706
tools/mb/mb.py:706: def WriteJSON(self, obj, path, verbosity=1):
add comment explaining what verbosity means (if it's only 0/1 in practice, make
it a bool)

[Dirk Pranke, 2015-09-11 23:33:03]

On 2015/09/11 23:31:16, Nico wrote:
> (somewhat stampy) lgtm, thanks!
> 
> https://codereview.chromium.org/1342563002/diff/80001/tools/mb/mb.py
> File tools/mb/mb.py (right):
> 
>
https://codereview.chromium.org/1342563002/diff/80001/tools/mb/mb.py#newcode706
> tools/mb/mb.py:706: def WriteJSON(self, obj, path, verbosity=1):
> add comment explaining what verbosity means (if it's only 0/1 in practice,
make
> it a bool)

Will do.

[Dirk Pranke, 2015-09-11 23:42:28]

On 2015/09/11 23:33:03, Dirk Pranke wrote:
> On 2015/09/11 23:31:16, Nico wrote:
>
https://codereview.chromium.org/1342563002/diff/80001/tools/mb/mb.py#newcode706
> > tools/mb/mb.py:706: def WriteJSON(self, obj, path, verbosity=1):
> > add comment explaining what verbosity means (if it's only 0/1 in practice,
> make
> > it a bool)
> 
> Will do.

Done. Let me know if this looks clear enough?

[Nico, 2015-09-12 00:09:40]

naming suggestion below, but if you prefer what you have it's cool as-is too

https://codereview.chromium.org/1342563002/diff/100001/tools/mb/mb.py
File tools/mb/mb.py (right):

https://codereview.chromium.org/1342563002/diff/100001/tools/mb/mb.py#newcode726
tools/mb/mb.py:726: def Run(self, cmd, env=None, verbose_only=False):
nit: I think it reads a bit better if this is called force_verbose and has its
true/false flipped (`if self.arg.verbose or force_verbose: print foo`)

[Dirk Pranke, 2015-09-12 00:16:18]

On 2015/09/12 00:09:40, Nico wrote:
> naming suggestion below, but if you prefer what you have it's cool as-is too
> 
> https://codereview.chromium.org/1342563002/diff/100001/tools/mb/mb.py
> File tools/mb/mb.py (right):
> 
>
https://codereview.chromium.org/1342563002/diff/100001/tools/mb/mb.py#newcode726
> tools/mb/mb.py:726: def Run(self, cmd, env=None, verbose_only=False):
> nit: I think it reads a bit better if this is called force_verbose and has its
> true/false flipped (`if self.arg.verbose or force_verbose: print foo`)

Yeah, that is a bit better, I think.

[Dirk Pranke, 2015-09-12 00:55:22]

The CQ bit was checked by dpranke@chromium.org

[Dirk Pranke, 2015-09-12 00:55:22]

The patchset sent to the CQ was uploaded after l-g-t-m from thakis@chromium.org
Link to the patchset: https://codereview.chromium.org/1342563002/#ps120001
(title: "s/verbose_only/force_verbose")

[commit-bot: I haz the power, 2015-09-12 00:56:27]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1342563002/120001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1342563002/120001

[commit-bot: I haz the power, 2015-09-12 03:58:17]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-09-12 03:58:18]

Try jobs failed on following builders:
  linux_chromium_asan_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_chromeos_ozone_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_clobber_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_gn_chromeos_rel on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_gn_dbg on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Dirk Pranke, 2015-09-14 19:40:06]

The CQ bit was checked by dpranke@chromium.org

[commit-bot: I haz the power, 2015-09-14 19:40:52]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1342563002/120001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1342563002/120001

[Dirk Pranke, 2015-09-14 20:54:21]

The CQ bit was unchecked by dpranke@chromium.org

[Dirk Pranke, 2015-09-14 21:08:02]

The CQ bit was checked by dpranke@chromium.org

[Dirk Pranke, 2015-09-14 21:08:02]

The patchset sent to the CQ was uploaded after l-g-t-m from thakis@chromium.org
Link to the patchset: https://codereview.chromium.org/1342563002/#ps140001
(title: "catch gn gen failure")

[commit-bot: I haz the power, 2015-09-14 21:08:17]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1342563002/140001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1342563002/140001

[commit-bot: I haz the power, 2015-09-15 01:27:45]

Committed patchset #4 (id:140001)

[commit-bot: I haz the power, 2015-09-15 01:28:25]

Patchset 4 (id:??) landed as
https://crrev.com/e0547cd084409dd5f6c336a2babb47ca28a66d1f
Cr-Commit-Position: refs/heads/master@{#348806}

[commit-bot: I haz the power, 2015-09-23 12:40:59]

Patchset 4 (id:??) landed as
https://crrev.com/e0547cd084409dd5f6c336a2babb47ca28a66d1f
Cr-Commit-Position: refs/heads/master@{#348806}