Issue 1342523002: json based animation toy

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1342523002: json based animation toy (Closed)

Created:
5 years, 3 months ago by caryclark

Modified:
5 years, 1 month ago

Reviewers:

CC:
reviews_skia.org

Base URL:
https://skia.googlesource.com/skia.git@master

Target Ref:
refs/heads/master

Project:
skia

Visibility:
Public.

More Reviews

Description

runs some sample animations side by side in canvas and svg TBR=fmalita@chromium.org Committed: https://skia.googlesource.com/skia/+/3257c12220c411cc9db564e6bf02baba4c1bc061

Patch Set 1 #

Patch Set 2 : move to its own dir #

Patch Set 3 : exclude vars that aren't animations #

Patch Set 4 : wip checkpoint (3 slides work) #

Patch Set 5 : wip checkpoint (4 slides work) #

Patch Set 6 : wip (5 slides work) #

Patch Set 7 : wip checkpoint - canvas not working #

Patch Set 8 : wip (not working) #

Patch Set 9 : wip working again #

Patch Set 10 : wip; whereever I left it #

Patch Set 11 : wip; try a json variant #

Patch Set 12 : wip; more json typing #

Patch Set 13 : wip; json compiles #

Patch Set 14 : wip; more json handling #

Patch Set 15 : wip #

Patch Set 16 : wip; go back to pure json #

Patch Set 17 : wip #

Patch Set 18 : wip #

Patch Set 19 : wip #

Patch Set 20 : wip #

Patch Set 21 : wip #

Patch Set 22 : wip #

Patch Set 23 : wip 1-4 work #

Patch Set 24 : wip canvas 1-7 works #

Patch Set 25 : wip; starting on svg #

Patch Set 26 : wip; more svg backend #

Patch Set 27 : wip split into files #

Patch Set 28 : wip canvas + svg working side-by-side #

Patch Set 29 : wip (remember to add all the files) #

Patch Set 30 : wip whats next? #

Created: 5 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3494 lines, -2 lines)			Patch
A	experimental/docs/animationCommon.js	View	1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28	1 chunk	+314 lines, -0 lines	0 comments	Download
A	experimental/docs/backend.js	View	1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27	1 chunk	+44 lines, -0 lines	0 comments	Download
A	experimental/docs/canvasBackend.js	View	1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26	1 chunk	+167 lines, -0 lines	0 comments	Download
A	experimental/docs/exampleSlides.js	View	1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27	1 chunk	+564 lines, -0 lines	0 comments	Download
A	experimental/docs/glMatrix-0.9.5.min.js	View	1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29	1 chunk	+32 lines, -0 lines	0 comments	Download
A	experimental/docs/interpolatorFunctions.js	View	1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27	1 chunk	+84 lines, -0 lines	0 comments	Download
A	experimental/docs/jsonReader.cpp	View	1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29	1 chunk	+66 lines, -0 lines	0 comments	Download
A	experimental/docs/jsonbaseddoc.htm	View	1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29	1 chunk	+41 lines, -0 lines	0 comments	Download
A	experimental/docs/lesson1.html	View	1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29	1 chunk	+198 lines, -0 lines	0 comments	Download
A	experimental/docs/svgBackend.js	View	1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27	1 chunk	+246 lines, -0 lines	0 comments	Download
A	experimental/docs/svgbaseddoc.htm	View	1 2 3 4 5 6 7 8 9	1 chunk	+1712 lines, -0 lines	0 comments	Download
A	experimental/docs/utilities.js	View	1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28	1 chunk	+24 lines, -0 lines	0 comments	Download
M	resources/slides.lua	View	1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29	2 chunks	+2 lines, -2 lines	0 comments	Download

Messages

Total messages: 4 (2 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1342523002/560001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1342523002/560001

5 years, 1 month ago (2015-11-16 21:21:32 UTC) #3

commit-bot: I haz the power

5 years, 1 month ago (2015-11-16 21:36:12 UTC) #4

Message was sent while issue was closed.

Committed patchset #29 (id:560001) as
https://skia.googlesource.com/skia/+/3257c12220c411cc9db564e6bf02baba4c1bc061

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages