Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(596)

Side by Side Diff: mojo/fetcher/base_application_fetcher.h

Issue 1342503003: Move fetching logic out of ApplicationManager, eliminate url mappings. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: . Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
(Empty)
1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file.
4
5 #include "base/files/file_path.h"
6 #include "mojo/fetcher/url_resolver.h"
7 #include "mojo/services/network/public/interfaces/network_service.mojom.h"
8 #include "mojo/services/network/public/interfaces/url_loader_factory.mojom.h"
9 #include "mojo/shell/application_fetcher.h"
10
11 namespace mojo {
12 namespace fetcher {
13
14 class BaseApplicationFetcher : public shell::ApplicationFetcher {
sky 2015/09/11 23:05:27 Description (it isn't clear that a base applicatio
15 public:
16 explicit BaseApplicationFetcher(const base::FilePath& shell_file_root);
17 ~BaseApplicationFetcher() override;
18
19 private:
20 // Overridden from shell::ApplicationFetcher:
21 void SetApplicationManager(shell::ApplicationManager* manager) override;
22 GURL ResolveURL(const GURL& url) override;
23 void FetchRequest(
24 URLRequestPtr request,
25 const shell::Fetcher::FetchCallback& loader_callback) override;
26
27 shell::ApplicationManager* application_manager_;
sky 2015/09/11 23:05:27 initialize to null.
28 scoped_ptr<URLResolver> url_resolver_;
29 bool disable_cache_;
sky 2015/09/11 23:05:27 nit: const
30 NetworkServicePtr network_service_;
31 URLLoaderFactoryPtr url_loader_factory_;
32
33 DISALLOW_COPY_AND_ASSIGN(BaseApplicationFetcher);
34 };
35
36 } // namespace fetcher
37 } // namespace mojo
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698