Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(213)

Issue 1342453004: [CSS Grid Layout] Combining Content and Self Alignment with span items (Closed)

Created:
5 years, 3 months ago by jfernandez
Modified:
5 years, 2 months ago
CC:
blink-reviews, jfernandez, szager+layoutwatch_chromium.org, zoltan1, svillar, pdr+renderingwatchlist_chromium.org, Manuel Rego, leviw+renderwatch, blink-reviews-rendering, jchaffraix+rendering, eae+blinkwatch
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[CSS Grid Layout] Combining Content and Self Alignment with span items Using the Content Alignment CSS properties we can add offsets to the grid tracks so they are not adjacent anymore. This requires to handle Self Alignment of items spanning more than one track in a special way, because grid item's area breadth is bigger than the tracks base size it occupies. In order to properly adjust the Self Alignment values we need to consider the offset between tracks. BUG=249451, 376823 Committed: https://crrev.com/42162f3d51bc0472475314a04661dfcc57096778 Cr-Commit-Position: refs/heads/master@{#352096}

Patch Set 1 #

Total comments: 1

Patch Set 2 : Applied suggersted changes. #

Patch Set 3 : Applied suggested changes. #

Patch Set 4 : Added comment. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+317 lines, -6 lines) Patch
A third_party/WebKit/LayoutTests/fast/css-grid-layout/grid-content-alignment-and-self-alignment.html View 1 1 chunk +245 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/fast/css-grid-layout/grid-content-alignment-and-self-alignment-expected.txt View 1 1 chunk +50 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutGrid.cpp View 1 4 chunks +22 lines, -6 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
jfernandez
5 years, 3 months ago (2015-09-11 21:50:47 UTC) #2
cbiesinger
lgtm, but I'd add a comment to the endOfColumn adjustment saying something similar to this ...
5 years, 2 months ago (2015-09-30 15:09:02 UTC) #3
cbiesinger
https://codereview.chromium.org/1342453004/diff/1/Source/core/layout/LayoutGrid.cpp File Source/core/layout/LayoutGrid.cpp (right): https://codereview.chromium.org/1342453004/diff/1/Source/core/layout/LayoutGrid.cpp#newcode1760 Source/core/layout/LayoutGrid.cpp:1760: return (distribution == ContentDistributionStretch || ContentDistributionStretch == ContentDistributionDefault) ? ...
5 years, 2 months ago (2015-09-30 15:09:10 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1342453004/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1342453004/60001
5 years, 2 months ago (2015-10-02 16:17:25 UTC) #7
commit-bot: I haz the power
Committed patchset #4 (id:60001)
5 years, 2 months ago (2015-10-02 19:03:52 UTC) #8
commit-bot: I haz the power
5 years, 2 months ago (2015-10-02 19:04:33 UTC) #9
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/42162f3d51bc0472475314a04661dfcc57096778
Cr-Commit-Position: refs/heads/master@{#352096}

Powered by Google App Engine
This is Rietveld 408576698