Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(481)

Unified Diff: Source/core/frame/UseCounter.cpp

Issue 1342443004: [MIGRATED] Make deprecation warnings on XHR's setRequestHeader more accurate (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@temp1288263003
Patch Set: Support CRLF on Windows. Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/core/frame/UseCounter.cpp
diff --git a/Source/core/frame/UseCounter.cpp b/Source/core/frame/UseCounter.cpp
index 2c8a68fd0d79a79c00af42b6df260495b55e3ab1..95ab2eae58ab1a256ae34ddf73be825d5aba3238 100644
--- a/Source/core/frame/UseCounter.cpp
+++ b/Source/core/frame/UseCounter.cpp
@@ -955,7 +955,10 @@ String UseCounter::deprecationMessage(Feature feature)
return "Request.context is deprecated and will be removed in M46 (see: https://www.chromestatus.com/feature/5534702526005248).";
case HeaderValueNotMatchingRFC7230:
- return "Header values not matching to RFC 7230, will be deprecated (see: https://www.chromestatus.com/feature/6457425448140800).";
+ return "Header values not matching to RFC 7230 (containing invalid octets). We are experimenting whether such header values can be deprecated (see: https://www.chromestatus.com/feature/6457425448140800).";
tyoshino (SeeGerritForStatus) 2015/09/25 13:01:35 "Found a header value that doesn't match the field
hiroshige 2015/09/29 05:19:09 Done.
+
+ case XHRSetRequestHeaderAffectedByNormalize:
+ return "setRequestHeader() affected by header value normalization (header values with leading/trailing whitespaces). We are experimenting whether such whitespaces can be stripped according to the latest spec (see: https://www.chromestatus.com/feature/6457425448140800).";
tyoshino (SeeGerritForStatus) 2015/09/25 13:01:35 According to the Fetch Standard, setRequestHeader(
hiroshige 2015/09/29 05:19:09 Done.
// Features that aren't deprecated don't have a deprecation message.
default:

Powered by Google App Engine
This is Rietveld 408576698