Telemetry: allow user to specify source type for synthetic gestures.

Telemetry: allow user to specify source type for synthetic gestures.

Introduce a new command line parameter '--synthetic-gesture-source-type' to
specify a specific source type (mouse or touch) for gesture actions. This
overwrites the target platform's default source type.

BUG=335424
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=249454

[Dominik Grewe, 2014-01-31 17:57:21]

PTAL. Not sure if BrowserOptions is the right place because we're not passing
the value as a browser parameter, but I didn't see a better option for it.

[nduca, 2014-02-04 01:19:18]

i must have forgotten a bit of the context on why we want this.

can we do it more as a action-specific thing instead of touching the global
browser state?

e.g. make gpuBenchmarkingExtension tell us what the native option of events
usually are, but also let any action specify by hand whether it needs a specific
one? E.g. {action: scroll, force_touch_events: true}. And, have the
gpuBenchmarkingExtnesion check the synth-gesture class to see if its supported
and explode if not?

[Dominik Grewe, 2014-02-04 09:29:47]

On 2014/02/04 01:19:18, nduca wrote:
> i must have forgotten a bit of the context on why we want this.

Yufeng asked me to do this. The motivation was that he wanted to test
touch-scrolling on ChromeOS, which by default uses mouse input. Rather than
changing each scroll action in the page set we thought it's easier to pass in a
parameter that overwrites the default behaviour.


> can we do it more as a action-specific thing instead of touching the global
> browser state?
> 
> e.g. make gpuBenchmarkingExtension tell us what the native option of events
> usually are, but also let any action specify by hand whether it needs a
specific
> one? E.g. {action: scroll, force_touch_events: true}. And, have the
> gpuBenchmarkingExtnesion check the synth-gesture class to see if its supported
> and explode if not?

We've already got something like this (see 'scroll_requires_touch').

[nduca, 2014-02-04 19:24:03]

Oh, I see. Hmm... how about --force-use-touch-events-in-synthetic-gestures since
thats really the more common case? LGTM otherwise.

[Dominik Grewe, 2014-02-04 19:28:44]

On 2014/02/04 19:24:03, nduca wrote:
> Oh, I see. Hmm... how about --force-use-touch-events-in-synthetic-gestures
since
> thats really the more common case? LGTM otherwise.

Thought it would be nicer to keep it general. If we want to support mouse input
for Android at some point we might want to do the opposite (send mouse instead
of the default touch).

[Dominik Grewe, 2014-02-06 10:47:48]

The CQ bit was checked by dominikg@chromium.org

[commit-bot: I haz the power, 2014-02-06 10:49:57]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/dominikg@chromium.org/134243004/130001

[commit-bot: I haz the power, 2014-02-06 12:30:52]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-02-06 12:30:53]

Retried try job too often on win_rel for step(s) telemetry_perf_unittests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&nu...

[Dominik Grewe, 2014-02-06 13:22:31]

The CQ bit was checked by dominikg@chromium.org

[commit-bot: I haz the power, 2014-02-06 13:23:07]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/dominikg@chromium.org/134243004/130001

[commit-bot: I haz the power, 2014-02-06 13:36:48]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/dominikg@chromium.org/134243004/130001

[commit-bot: I haz the power, 2014-02-06 18:31:39]

Change committed as 249454