Create separate telemetry media-perf ChromeOS benchmarks for 4k and non-4k content.

Add labels to media test pages that play 4K and/or 50FPS content.
Create 2 benchmarks for ChromeOS devices, one playing only 4-content, the other playing all other test content.

BUG=339837
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=248876

[shadi1, 2014-01-31 17:50:39]

https://codereview.chromium.org/134243003/diff/1/tools/perf/benchmarks/media.py
File tools/perf/benchmarks/media.py (right):

https://codereview.chromium.org/134243003/diff/1/tools/perf/benchmarks/media....
tools/perf/benchmarks/media.py:41: 'page_filter_exclude': '.*(crowd|garden).*'
Can we update this to use labels for consistency?

[anandc, 2014-01-31 17:58:47]

PTAL. Thanks.

https://codereview.chromium.org/134243003/diff/1/tools/perf/benchmarks/media.py
File tools/perf/benchmarks/media.py (right):

https://codereview.chromium.org/134243003/diff/1/tools/perf/benchmarks/media....
tools/perf/benchmarks/media.py:41: 'page_filter_exclude': '.*(crowd|garden).*'
On 2014/01/31 17:50:39, shadi1 wrote:
> Can we update this to use labels for consistency?

Done.

[shadi1, 2014-01-31 18:02:57]

LGTM

[anandc, 2014-01-31 21:27:12]

PTAL at patch #3. 
With this patch, we apply filters so that there is no overlap of test-pages
between the 2 ChromeOS benchmarks. This avoids the same test being run twice on
the same platform.

[Pawel Osciak, 2014-01-31 23:50:26]

https://codereview.chromium.org/134243003/diff/120003/tools/perf/benchmarks/m...
File tools/perf/benchmarks/media.py (right):

https://codereview.chromium.org/134243003/diff/120003/tools/perf/benchmarks/m...
tools/perf/benchmarks/media.py:50: options = {'page_label_filter': '4k',
Could you please explain what decides whether this test is run on device? The
4k_video label on a bot?

https://codereview.chromium.org/134243003/diff/120003/tools/perf/benchmarks/m...
tools/perf/benchmarks/media.py:64: options = {'page_label_filter_exclude':
'4k,50fps'}
Does this mean we don't want to test 50fps on any ChromeOS devices?

https://codereview.chromium.org/134243003/diff/120003/tools/perf/page_sets/to...
File tools/perf/page_sets/tough_video_cases.json (right):

https://codereview.chromium.org/134243003/diff/120003/tools/perf/page_sets/to...
tools/perf/page_sets/tough_video_cases.json:109: "4k": true
Is this a 1080p video not 4k (from the filename)?

[anandc, 2014-02-01 00:58:41]

Thanks for the comments. PTAL at ps#4.

https://codereview.chromium.org/134243003/diff/120003/tools/perf/benchmarks/m...
File tools/perf/benchmarks/media.py (right):

https://codereview.chromium.org/134243003/diff/120003/tools/perf/benchmarks/m...
tools/perf/benchmarks/media.py:50: options = {'page_label_filter': '4k',
On 2014/01/31 23:50:27, Pawel Osciak wrote:
> Could you please explain what decides whether this test is run on device? The
> 4k_video label on a bot?

That's right. This benchmark runs only on pages that have 4K content. Then, on
the ChromeOS side, the control file that runs this benchmark would have a
dependency on 4k_video.

https://codereview.chromium.org/134243003/diff/120003/tools/perf/benchmarks/m...
tools/perf/benchmarks/media.py:64: options = {'page_label_filter_exclude':
'4k,50fps'}
On 2014/01/31 23:50:27, Pawel Osciak wrote:
> Does this mean we don't want to test 50fps on any ChromeOS devices?

We do. 

There was a problem with 50fps content timing out. We'd like to get 4K, 24fps
tests running reliably first. Once those are running OK on ChromeOS, we can
re-enable 50fps content as well.

https://codereview.chromium.org/134243003/diff/120003/tools/perf/page_sets/to...
File tools/perf/page_sets/tough_video_cases.json (right):

https://codereview.chromium.org/134243003/diff/120003/tools/perf/page_sets/to...
tools/perf/page_sets/tough_video_cases.json:109: "4k": true
On 2014/01/31 23:50:27, Pawel Osciak wrote:
> Is this a 1080p video not 4k (from the filename)?

Thank you. Fixed.

[anandc, 2014-02-03 21:08:58]

Ping. PTAL. Thanks.

[dtu, 2014-02-03 23:25:38]

lgtm

[anandc, 2014-02-04 04:53:50]

The CQ bit was checked by anandc@chromium.org

[commit-bot: I haz the power, 2014-02-04 04:55:21]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/anandc@chromium.org/134243003/280001

[commit-bot: I haz the power, 2014-02-04 05:57:41]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-02-04 05:57:42]

Retried try job too often on linux_rel for step(s) sync_integration_tests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_rel&...

[anandc, 2014-02-04 06:10:27]

The CQ bit was checked by anandc@chromium.org

[commit-bot: I haz the power, 2014-02-04 06:11:03]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/anandc@chromium.org/134243003/280001

[commit-bot: I haz the power, 2014-02-04 07:14:33]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-02-04 07:14:34]

Retried try job too often on ios_dbg_simulator for step(s) url_unittests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=ios_dbg_si...

[anandc, 2014-02-04 14:33:37]

The CQ bit was checked by anandc@chromium.org

[commit-bot: I haz the power, 2014-02-04 14:33:43]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/anandc@chromium.org/134243003/280001

[commit-bot: I haz the power, 2014-02-04 15:35:45]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-02-04 15:35:46]

Retried try job too often on ios_dbg_simulator for step(s) url_unittests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=ios_dbg_si...

[skia-commit-bot, 2014-02-04 15:35:56]

CQ bit was unchecked on CL. Ignoring.

[anandc, 2014-02-04 16:17:33]

The CQ bit was checked by anandc@chromium.org

[commit-bot: I haz the power, 2014-02-04 16:18:13]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/anandc@chromium.org/134243003/280001

[commit-bot: I haz the power, 2014-02-04 17:46:41]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-02-04 17:46:42]

Retried try job too often on linux_rel for step(s) base_unittests,
browser_tests, interactive_ui_tests, net_unittests, sync_integration_tests,
unit_tests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_rel&...

[anandc, 2014-02-04 18:26:37]

The CQ bit was checked by anandc@chromium.org

[commit-bot: I haz the power, 2014-02-04 18:28:44]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/anandc@chromium.org/134243003/280001

[commit-bot: I haz the power, 2014-02-04 20:36:50]

Retried try job too often on linux_rel for step(s) base_unittests,
browser_tests, interactive_ui_tests, net_unittests, sync_integration_tests,
unit_tests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_rel&...

[commit-bot: I haz the power, 2014-02-04 20:39:24]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/anandc@chromium.org/134243003/280001

[commit-bot: I haz the power, 2014-02-05 00:53:08]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/anandc@chromium.org/134243003/280001

[commit-bot: I haz the power, 2014-02-05 06:27:37]

Change committed as 248876