Issue 134243002: remove poplar building from mac, until it is fixed

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 134243002: remove poplar building from mac, until it is fixed (Closed)

Created:
6 years, 11 months ago by reed1

Modified:
6 years, 11 months ago

Reviewers:
vandebo (ex-Chrome), mtklein, epoger

CC:
skia-review_googlegroups.com

Base URL:
https://skia.googlecode.com/svn/trunk

Visibility:
Public.

More Reviews

Description

remove poplar building from mac, until it is fixed BUG=skia:2008 Committed: http://code.google.com/p/skia/source/detail?r=13020

Patch Set 1 #

Total comments: 1

Created: 6 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	gyp/common_variables.gypi	View		1 chunk	+1 line, -1 line	1 comment	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/reed@google.com/134243002/1

6 years, 11 months ago (2014-01-10 16:58:38 UTC) #3

epoger

lgtm https://codereview.chromium.org/134243002/diff/1/gyp/common_variables.gypi File gyp/common_variables.gypi (right): https://codereview.chromium.org/134243002/diff/1/gyp/common_variables.gypi#newcode60 gyp/common_variables.gypi:60: [ 'skia_os in ["linux", "win"]', { maybe add ...

6 years, 11 months ago (2014-01-10 16:59:37 UTC) #4

Message was sent while issue was closed.

Change committed as 13020

Expand Messages | Collapse Messages