fpdfsdk/src/javascript/JS_Runtime.cpp - Issue 1342403005: Merge to XFA: Don't pass null isolates to FXJS_ when we have a real isolate.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: fpdfsdk/src/javascript/JS_Runtime.cpp

Issue 1342403005: Merge to XFA: Don't pass null isolates to FXJS_ when we have a real isolate. (Closed) Base URL: https://pdfium.googlesource.com/pdfium.git@xfa

Patch Set: Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: fpdfsdk/src/javascript/JS_Runtime.cpp

diff --git a/fpdfsdk/src/javascript/JS_Runtime.cpp b/fpdfsdk/src/javascript/JS_Runtime.cpp

index bbe9f6e8c82477efacfb4caab061b7f436e12a73..643cefb92fcd9fbac6501c3271623dd5c1ce9114 100644

--- a/fpdfsdk/src/javascript/JS_Runtime.cpp

+++ b/fpdfsdk/src/javascript/JS_Runtime.cpp

@@ -205,7 +205,7 @@ void CJS_Runtime::SetReaderDocument(CPDFSDK_Document* pReaderDoc) {

if (FXJS_GetObjDefnID(pThis) ==

FXJS_GetObjDefnID(GetIsolate(), L"Document")) {

if (CJS_Document* pJSDocument =

- (CJS_Document*)FXJS_GetPrivate(pThis)) {

+ (CJS_Document*)FXJS_GetPrivate(GetIsolate(), pThis)) {

if (Document* pDocument = (Document*)pJSDocument->GetEmbedObject())

pDocument->AttachDoc(pReaderDoc);

}

« no previous file with comments | « fpdfsdk/src/javascript/JS_EventHandler.cpp ('k') | fpdfsdk/src/jsapi/fxjs_v8.cpp » ('j') | no next file with comments »