fpdfsdk/src/javascript/Document.cpp - Issue 1342403005: Merge to XFA: Don't pass null isolates to FXJS_ when we have a real isolate.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: fpdfsdk/src/javascript/Document.cpp

Issue 1342403005: Merge to XFA: Don't pass null isolates to FXJS_ when we have a real isolate. (Closed) Base URL: https://pdfium.googlesource.com/pdfium.git@xfa

Patch Set: Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: fpdfsdk/src/javascript/Document.cpp

diff --git a/fpdfsdk/src/javascript/Document.cpp b/fpdfsdk/src/javascript/Document.cpp

index bccf08b2710c76b919df78fbf64e8cb5af321daa..105e487e1ca6a288e745860b23038b2c0116b1ca 100644

--- a/fpdfsdk/src/javascript/Document.cpp

+++ b/fpdfsdk/src/javascript/Document.cpp

@@ -1467,7 +1467,7 @@ FX_BOOL Document::icons(IFXJS_Context* cc,

if (pObj.IsEmpty())

return FALSE;

- CJS_Icon* pJS_Icon = (CJS_Icon*)FXJS_GetPrivate(pObj);

+ CJS_Icon* pJS_Icon = (CJS_Icon*)FXJS_GetPrivate(m_isolate, pObj);

if (!pJS_Icon)

return FALSE;

@@ -1511,7 +1511,7 @@ FX_BOOL Document::getIcon(IFXJS_Context* cc,

if (pObj.IsEmpty())

return FALSE;

- CJS_Icon* pJS_Icon = (CJS_Icon*)FXJS_GetPrivate(pObj);

+ CJS_Icon* pJS_Icon = (CJS_Icon*)FXJS_GetPrivate(m_isolate, pObj);

if (!pJS_Icon)

return FALSE;

« no previous file with comments | « fpdfsdk/include/jsapi/fxjs_v8.h ('k') | fpdfsdk/src/javascript/Field.cpp » ('j') | no next file with comments »