Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(27)

Issue 134233002: Disable the Run option in context menu for blocked plugins if they were blocked by policy. (Closed)

Created:
6 years, 11 months ago by Bernhard Bauer
Modified:
6 years, 11 months ago
CC:
chromium-reviews, stuartmorgan+watch_chromium.org, jam
Visibility:
Public.

Description

Disable the Run option in the context menu for blocked plugins if they were blocked by policy. BUG=321772 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=244555

Patch Set 1 #

Patch Set 2 : review #

Patch Set 3 : fix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+33 lines, -8 lines) Patch
M chrome/browser/plugins/plugin_info_message_filter.h View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/plugins/plugin_info_message_filter.cc View 4 chunks +12 lines, -6 lines 0 comments Download
M chrome/common/render_messages.h View 1 2 2 chunks +3 lines, -1 line 0 comments Download
M chrome/renderer/chrome_content_renderer_client.cc View 1 1 chunk +16 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (0 generated)
Bernhard Bauer
Please review.
6 years, 11 months ago (2014-01-10 16:52:03 UTC) #1
markusheintz_
On 2014/01/10 16:52:03, Bernhard Bauer wrote: > Please review. LGTM Thanks a lot for creating ...
6 years, 11 months ago (2014-01-13 12:04:50 UTC) #2
Bernhard Bauer
Adding OWNERS: Jochen for chrome/renderer, Justin for IPC changes (adding a value to an enum ...
6 years, 11 months ago (2014-01-13 12:07:34 UTC) #3
jschuh
Would you mind converting this to use IPC_ENUM_TRAITS_MAX_VALUE?
6 years, 11 months ago (2014-01-13 14:34:23 UTC) #4
jochen (gone - plz use gerrit)
lgtm
6 years, 11 months ago (2014-01-13 14:44:55 UTC) #5
Bernhard Bauer
On 2014/01/13 14:34:23, Justin Schuh wrote: > Would you mind converting this to use IPC_ENUM_TRAITS_MAX_VALUE? ...
6 years, 11 months ago (2014-01-13 14:54:15 UTC) #6
jschuh
On 2014/01/13 14:54:15, Bernhard Bauer wrote: > On 2014/01/13 14:34:23, Justin Schuh wrote: > > ...
6 years, 11 months ago (2014-01-13 15:00:51 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/bauerb@chromium.org/134233002/130001
6 years, 11 months ago (2014-01-13 15:03:34 UTC) #8
commit-bot: I haz the power
Retried try job too often on mac_rel for step(s) base_unittests, browser_tests, interactive_ui_tests, net_unittests, unit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=mac_rel&number=210978
6 years, 11 months ago (2014-01-13 15:21:55 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/bauerb@chromium.org/134233002/410001
6 years, 11 months ago (2014-01-13 17:44:20 UTC) #10
commit-bot: I haz the power
6 years, 11 months ago (2014-01-13 19:39:44 UTC) #11
Message was sent while issue was closed.
Change committed as 244555

Powered by Google App Engine
This is Rietveld 408576698