Replace calls to rand_s with calls to RtlGenRandom

Replace calls to rand_s with calls to RtlGenRandom.

Add a test for GetGranularAlignedRandomOffset.

This potentially fixes two similar crashes in sandbox::ApplyProcessMitigationsToSuspendedProcess and sandbox::InterceptionManager::PatchNtdll.

BUG=379218, 501813
TEST=sbox_unittests

Committed: https://crrev.com/f4b1928eaa63736de442317980682bcf1244bd17
Cr-Commit-Position: refs/heads/master@{#349748}

[Will Harris, 2015-09-16 01:31:07]

wfh@chromium.org changed reviewers:
+ jschuh@chromium.org

[Will Harris, 2015-09-16 03:24:39]

PTAL

[Will Harris, 2015-09-16 16:54:46]

The #define that is needed to get to SystemFunction036 messes up other #includes
that are needed for using NT* functions/definitions in these files, so I have
pulled the random code into a separate file to isolate the crazy.

PTAL

[jschuh, 2015-09-17 23:40:18]

Thanks for switching it to RtlGenRandom. lgtm with one nit.

https://codereview.chromium.org/1342303003/diff/40001/sandbox/win/src/sandbox...
File sandbox/win/src/sandbox_rand.cc (right):

https://codereview.chromium.org/1342303003/diff/40001/sandbox/win/src/sandbox...
sandbox/win/src/sandbox_rand.cc:20: RtlGenRandom(random_value, sizeof(unsigned
int)) != FALSE;
NIT: Please just tweak this to:

return RtlGenRandom(random_value, sizeof(unsigned int)) != FALSE;

[Will Harris, 2015-09-18 19:08:19]

thanks for the review

https://codereview.chromium.org/1342303003/diff/40001/sandbox/win/src/sandbox...
File sandbox/win/src/sandbox_rand.cc (right):

https://codereview.chromium.org/1342303003/diff/40001/sandbox/win/src/sandbox...
sandbox/win/src/sandbox_rand.cc:20: RtlGenRandom(random_value, sizeof(unsigned
int)) != FALSE;
On 2015/09/17 23:40:18, jschuh (very slow) wrote:
> NIT: Please just tweak this to:
> 
> return RtlGenRandom(random_value, sizeof(unsigned int)) != FALSE;

Done.

[Will Harris, 2015-09-18 19:08:24]

The CQ bit was checked by wfh@chromium.org

[Will Harris, 2015-09-18 19:08:25]

The patchset sent to the CQ was uploaded after l-g-t-m from jschuh@chromium.org
Link to the patchset: https://codereview.chromium.org/1342303003/#ps60001
(title: "fix nit")

[commit-bot: I haz the power, 2015-09-18 19:09:20]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1342303003/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1342303003/60001

[commit-bot: I haz the power, 2015-09-18 20:02:57]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2015-09-18 20:03:42]

Patchset 4 (id:??) landed as
https://crrev.com/f4b1928eaa63736de442317980682bcf1244bd17
Cr-Commit-Position: refs/heads/master@{#349748}