Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(43)

Side by Side Diff: .gn

Issue 1342293002: Move `gn check` into the `generate_build_files` step. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: back out installer changes, do not check //chrome/installer Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | components/html_viewer/BUILD.gn » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # This file is used by the GN meta build system to find the root of the source 1 # This file is used by the GN meta build system to find the root of the source
2 # tree and to set startup options. For documentation on the values set in this 2 # tree and to set startup options. For documentation on the values set in this
3 # file, run "gn help dotfile" at the command line. 3 # file, run "gn help dotfile" at the command line.
4 4
5 # The location of the build configuration file. 5 # The location of the build configuration file.
6 buildconfig = "//build/config/BUILDCONFIG.gn" 6 buildconfig = "//build/config/BUILDCONFIG.gn"
7 7
8 # The secondary source root is a parallel directory tree where 8 # The secondary source root is a parallel directory tree where
9 # GN build files are placed when they can not be placed directly 9 # GN build files are placed when they can not be placed directly
10 # in the source tree, e.g. for third party source trees. 10 # in the source tree, e.g. for third party source trees.
11 secondary_source = "//build/secondary/" 11 secondary_source = "//build/secondary/"
12 12
13 # These are the targets to check headers for by default. The files in targets 13 # These are the targets to check headers for by default. The files in targets
14 # matching these patterns (see "gn help label_pattern" for format) will have 14 # matching these patterns (see "gn help label_pattern" for format) will have
15 # their includes checked for proper dependencies when you run either 15 # their includes checked for proper dependencies when you run either
16 # "gn check" or "gn gen --check". 16 # "gn check" or "gn gen --check".
17 check_targets = [ 17 check_targets = [
18 #"//apps/*", # Medium-hard. 18 #"//apps/*", # Medium-hard.
19 #"//ash/*", # Medium-hard. 19 #"//ash/*", # Medium-hard.
20 #"//base/*", # Needs GN binary changes to work on Android. 20 #"//base/*", # Needs GN binary changes to work on Android.
21 "//blink/*", 21 "//blink/*",
22 "//breakpad/*", 22 "//breakpad/*",
23 "//build/*", 23 "//build/*",
24 "//cc/*", 24 "//cc/*",
25 25
26 #"//chrome/*", # Epic number of errors. 26 #"//chrome/*", # Epic number of errors.
27 "//chrome/installer/*", 27 #"//chrome/installer/*", # A few errors, need to verify the size after fixing.
28 "//chromecast/*", 28 "//chromecast/*",
29 29
30 # TODO(brettw): Fix http://crbug.com/460828 and uncomment the following 30 # TODO(brettw): Fix http://crbug.com/460828 and uncomment the following
31 # line. 31 # line.
32 #"//chrome_elf/*", 32 #"//chrome_elf/*",
33 "//cloud_print/*", 33 "//cloud_print/*",
34 34
35 #"//components/*", # Lots of errors. 35 #"//components/*", # Lots of errors.
36 "//components/app_modal/*", 36 "//components/app_modal/*",
37 "//components/autofill/*", 37 "//components/autofill/*",
38 "//components/bookmarks/*", 38 "//components/bookmarks/*",
39 "//components/google/*", 39 "//components/google/*",
40 "//components/history/*", 40 "//components/history/*",
41 "//components/html_viewer/*", 41
42 # TODO(dpranke): Reenable once v8 exports v8_base as a public_dep
43 #"//components/html_viewer/*",
44
42 "//components/mus/*", 45 "//components/mus/*",
43 "//components/omnibox/*", 46 "//components/omnibox/*",
44 "//components/os_crypt/*", 47 "//components/os_crypt/*",
45 "//components/pref_registry/*", 48 "//components/pref_registry/*",
46 "//components/undo/*", 49 "//components/undo/*",
47 "//components/update_client/*", 50 "//components/update_client/*",
48 "//components/url_formatter/*", 51 "//components/url_formatter/*",
49 "//components/url_matcher/*", 52 "//components/url_matcher/*",
50 "//components/user_manager/*", 53 "//components/user_manager/*",
51 "//components/user_prefs/*", 54 "//components/user_prefs/*",
(...skipping 156 matching lines...) Expand 10 before | Expand all | Expand 10 after
208 "//tools/gn/format_test_data/055.golden", 211 "//tools/gn/format_test_data/055.golden",
209 "//tools/gn/function_exec_script.cc", 212 "//tools/gn/function_exec_script.cc",
210 "//tools/gn/gn.gyp", 213 "//tools/gn/gn.gyp",
211 "//tools/gn/input_conversion.cc", 214 "//tools/gn/input_conversion.cc",
212 "//tools/gn/misc/emacs/gn.el", 215 "//tools/gn/misc/emacs/gn.el",
213 "//tools/gn/misc/vim/syntax/gn.vim", 216 "//tools/gn/misc/vim/syntax/gn.vim",
214 "//tools/gn/setup.cc", 217 "//tools/gn/setup.cc",
215 "//ui/accessibility/BUILD.gn", 218 "//ui/accessibility/BUILD.gn",
216 "//ui/views/BUILD.gn", 219 "//ui/views/BUILD.gn",
217 ] 220 ]
OLDNEW
« no previous file with comments | « no previous file | components/html_viewer/BUILD.gn » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698