Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(579)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1342283004: Benchmark all mutex implementations. (Closed)

Created:
5 years, 3 months ago by herb_g
Modified:
5 years, 3 months ago
Reviewers:
mtklein
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Benchmark all mutex implementations. BUG=skia: Committed: https://skia.googlesource.com/skia/+/bcfd511eb1aada39622116fd1df8178b58650fba

Patch Set 1 #

Patch Set 2 : shared mutex benchmark #

Patch Set 3 : after sync #

Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -0 lines) Patch
M bench/MutexBench.cpp View 1 2 1 chunk +25 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
herb_g
5 years, 3 months ago (2015-09-18 16:11:07 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1342283004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1342283004/1
5 years, 3 months ago (2015-09-18 16:11:15 UTC) #4
commit-bot: I haz the power
Note for Reviewers: The CQ is waiting for an approval. If you believe that the ...
5 years, 3 months ago (2015-09-18 16:11:16 UTC) #5
mtklein
lgtm Want to add acquireShared() releaseShared() too for SkSharedMutex? Seems easy to neglect.
5 years, 3 months ago (2015-09-18 16:22:24 UTC) #6
commit-bot: I haz the power
5 years, 3 months ago (2015-09-18 16:24:21 UTC) #7
Message was sent while issue was closed. 
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/bcfd511eb1aada39622116fd1df8178b58650fba

Powered by Google App Engine
This is Rietveld 408576698