Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(354)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1342263004: DOC: Mention install_dependencies in Android quickstart (Closed)

Created:
5 years, 3 months ago by tomhudson
Modified:
5 years, 3 months ago
Reviewers:
jcgregorio, hcm
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

DOC: Mention install_dependencies in Android quickstart Embeds #prerequisites anchor in Linux so we don't duplicate the details. TBR=hcm,jcgregorio NOTRY=true DOCS_PREVIEW= https://skia.org/?cl=1342263004 Committed: https://skia.googlesource.com/skia/+/2582dc539542b1c50e7a16e2a5b460fbb12074e5

Patch Set 1 #

Patch Set 2 : Densify #

Total comments: 2

Patch Set 3 : Joe's fix #

Patch Set 4 : Fix indent #

Patch Set 5 : You got your code in my pre #

Patch Set 6 : Try to prettify #

Patch Set 7 : android and linux formatting never the twain shall meet #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -1 line) Patch
M site/user/quick/android.md View 1 2 3 4 5 6 1 chunk +4 lines, -0 lines 0 comments Download
M site/user/quick/linux.md View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 9 (1 generated)
tomhudson
Joe, this CL looks fine in the local preview docserver, even following the preview link ...
5 years, 3 months ago (2015-09-17 14:58:49 UTC) #1
jcgregorio
https://codereview.chromium.org/1342263004/diff/20001/site/user/quick/android.md File site/user/quick/android.md (right): https://codereview.chromium.org/1342263004/diff/20001/site/user/quick/android.md#newcode25 site/user/quick/android.md:25: <!--?prettify lang=sh?--> I think what you want is: <pre ...
5 years, 3 months ago (2015-09-17 15:06:40 UTC) #2
jcgregorio
https://codereview.chromium.org/1342263004/diff/20001/site/user/quick/android.md File site/user/quick/android.md (right): https://codereview.chromium.org/1342263004/diff/20001/site/user/quick/android.md#newcode25 site/user/quick/android.md:25: <!--?prettify lang=sh?--> I may have misspoke. I think the ...
5 years, 3 months ago (2015-09-17 15:12:07 UTC) #3
tomhudson
D'oh, I was paying so much attention to the link I didn't notice the other ...
5 years, 3 months ago (2015-09-17 15:12:30 UTC) #4
tomhudson
Patch set 7 just does the same thing all the other entries in the Android ...
5 years, 3 months ago (2015-09-17 15:20:02 UTC) #5
jcgregorio
lgtm
5 years, 3 months ago (2015-09-17 15:23:16 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1342263004/120001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1342263004/120001
5 years, 3 months ago (2015-09-17 15:27:40 UTC) #8
commit-bot: I haz the power
5 years, 3 months ago (2015-09-17 15:28:21 UTC) #9
Message was sent while issue was closed. 
Committed patchset #7 (id:120001) as
https://skia.googlesource.com/skia/+/2582dc539542b1c50e7a16e2a5b460fbb12074e5

Powered by Google App Engine
This is Rietveld 408576698