Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(41)

Issue 1342263003: [test] Allow passing extra flags to perf tryjobs. (Closed)

Created:
5 years, 3 months ago by Michael Achenbach
Modified:
5 years, 3 months ago
CC:
v8-reviews_googlegroups.com, gdeepti, Mircea Trofin, bradnelson
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[test] Allow passing extra flags to perf tryjobs. NOTRY=true Committed: https://crrev.com/ba67a42629859c8c5c859acfd46b96ed3ac85da8 Cr-Commit-Position: refs/heads/master@{#30817}

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -2 lines) Patch
M tools/try_perf.py View 1 3 chunks +9 lines, -2 lines 0 comments Download

Messages

Total messages: 10 (2 generated)
Michael Achenbach
PTAL. The test tryjob runs with extra flags.
5 years, 3 months ago (2015-09-17 14:39:24 UTC) #2
Michael Achenbach
Hmm - hold on - something's not right yet...
5 years, 3 months ago (2015-09-17 14:40:20 UTC) #3
Michael Achenbach
PTAL - everything was right - I just ran into a pitfall - now I ...
5 years, 3 months ago (2015-09-18 07:31:13 UTC) #4
Jakob Kummerow
lgtm
5 years, 3 months ago (2015-09-18 08:00:10 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1342263003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1342263003/20001
5 years, 3 months ago (2015-09-18 08:05:21 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 3 months ago (2015-09-18 08:06:20 UTC) #8
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/ba67a42629859c8c5c859acfd46b96ed3ac85da8 Cr-Commit-Position: refs/heads/master@{#30817}
5 years, 3 months ago (2015-09-18 08:06:41 UTC) #9
Michael Achenbach
5 years, 3 months ago (2015-09-18 09:10:08 UTC) #10
Message was sent while issue was closed.
Actually, what I thought was a pitfall also works. Was fixed yesterday by
Bradley: https://codereview.chromium.org/1349633004/

Powered by Google App Engine
This is Rietveld 408576698