Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(134)

Issue 1342243005: X87: [ic] Also collect known map for relational comparison. (Closed)

Created:
5 years, 3 months ago by chunyang.dai
Modified:
5 years, 3 months ago
Reviewers:
Weiliang
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

X87: [ic] Also collect known map for relational comparison. port e56f265f6d41fadbcea2be65d9b573bad8b4709d (r30852). original commit message: Previously we only collected the known map for equality comparisons. But if we also collect it for relational comparisons, we can inline a fast path of ToPrimitive on the objects, which is especially interesting since both sides have the same map. For now we only inline a very limited subset of ToPrimitive in Crankshaft, which is when the receiver map (and its prototype chain) doesn't have @@toPrimitive, and both valueOf and toString are the default versions on the %ObjectPrototype%. In this case the relational comparison would reduce to a string comparison of "[object CLASS]" with itself and so we can reduce that to a boolean constant plus map checks on both left and right hand side, plus code dependencies on the prototype chain. This repairs the regression on box2d. BUG= Committed: https://crrev.com/687ef62eb5e78f3ac9dcde3ed70f6b7dddf680ef Cr-Commit-Position: refs/heads/master@{#30897}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -6 lines) Patch
M src/x87/code-stubs-x87.cc View 1 chunk +15 lines, -6 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
chunyang.dai
PTAL
5 years, 3 months ago (2015-09-23 06:22:32 UTC) #2
Weiliang
lgtm
5 years, 3 months ago (2015-09-24 03:11:25 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1342243005/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1342243005/1
5 years, 3 months ago (2015-09-24 03:11:37 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 3 months ago (2015-09-24 03:34:55 UTC) #6
commit-bot: I haz the power
5 years, 3 months ago (2015-09-24 03:35:17 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/687ef62eb5e78f3ac9dcde3ed70f6b7dddf680ef
Cr-Commit-Position: refs/heads/master@{#30897}

Powered by Google App Engine
This is Rietveld 408576698