Implement git cl lint.

Implement git cl lint.

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=256289

[Lei Zhang, 2014-02-11 00:47:02]

Mostly copied over from gcl.py.

[iannucci, 2014-02-11 07:50:00]

https://codereview.chromium.org/134223010/diff/1/git_cl.py
File git_cl.py (right):

https://codereview.chromium.org/134223010/diff/1/git_cl.py#newcode1392
git_cl.py:1392: print "You need to install cpplint.py to lint C++ files."
No URL?

https://codereview.chromium.org/134223010/diff/1/git_cl.py#newcode1398
git_cl.py:1398: os.chdir(settings.GetRoot())
arg.... there's really no way to pass a base directory to ProcessFile? :(

changing cwd is my second least-favorite thing (right after using env vars to
pass state around).

https://codereview.chromium.org/134223010/diff/1/git_cl.py#newcode1422
git_cl.py:1422: return 0
this should probably return 0 iff cpplint._cpplint_state.error_count == 0 right?

[Lei Zhang, 2014-02-11 07:58:04]

https://codereview.chromium.org/134223010/diff/1/git_cl.py
File git_cl.py (right):

https://codereview.chromium.org/134223010/diff/1/git_cl.py#newcode1392
git_cl.py:1392: print "You need to install cpplint.py to lint C++ files."
On 2014/02/11 07:50:01, iannucci wrote:
> No URL?

I just copied this over from gcl.py. I'll come up with a better message.
cpplint.py and cpplint_chromium.py are right there in depot_tools.

https://codereview.chromium.org/134223010/diff/1/git_cl.py#newcode1398
git_cl.py:1398: os.chdir(settings.GetRoot())
On 2014/02/11 07:50:01, iannucci wrote:
> arg.... there's really no way to pass a base directory to ProcessFile? :(
> 
> changing cwd is my second least-favorite thing (right after using env vars to
> pass state around).

Again, almost blindly copied over from gcl.py. It looks like there is a --root
argument. Will give it a try.

https://codereview.chromium.org/134223010/diff/1/git_cl.py#newcode1422
git_cl.py:1422: return 0
On 2014/02/11 07:50:01, iannucci wrote:
> this should probably return 0 iff cpplint._cpplint_state.error_count == 0
right?

Sure, I can do that. Strangely, gcl lint always returns 1.

[iannucci, 2014-02-11 08:10:31]

On 2014/02/11 07:58:04, Lei Zhang wrote:
> https://codereview.chromium.org/134223010/diff/1/git_cl.py
> File git_cl.py (right):
> 
> https://codereview.chromium.org/134223010/diff/1/git_cl.py#newcode1392
> git_cl.py:1392: print "You need to install cpplint.py to lint C++ files."
> On 2014/02/11 07:50:01, iannucci wrote:
> > No URL?
> 
> I just copied this over from gcl.py. I'll come up with a better message.
> cpplint.py and cpplint_chromium.py are right there in depot_tools.
> 
> https://codereview.chromium.org/134223010/diff/1/git_cl.py#newcode1398
> git_cl.py:1398: os.chdir(settings.GetRoot())
> On 2014/02/11 07:50:01, iannucci wrote:
> > arg.... there's really no way to pass a base directory to ProcessFile? :(
> > 
> > changing cwd is my second least-favorite thing (right after using env vars
to
> > pass state around).
> 
> Again, almost blindly copied over from gcl.py. It looks like there is a --root
> argument. Will give it a try.
> 
> https://codereview.chromium.org/134223010/diff/1/git_cl.py#newcode1422
> git_cl.py:1422: return 0
> On 2014/02/11 07:50:01, iannucci wrote:
> > this should probably return 0 iff cpplint._cpplint_state.error_count == 0
> right?
> 
> Sure, I can do that. Strangely, gcl lint always returns 1.

1 is clearly more than 0, and therefore better :D

[Lei Zhang, 2014-02-11 22:20:52]

https://codereview.chromium.org/134223010/diff/1/git_cl.py
File git_cl.py (right):

https://codereview.chromium.org/134223010/diff/1/git_cl.py#newcode1398
git_cl.py:1398: os.chdir(settings.GetRoot())
On 2014/02/11 07:58:04, Lei Zhang wrote:
> On 2014/02/11 07:50:01, iannucci wrote:
> > arg.... there's really no way to pass a base directory to ProcessFile? :(
> > 
> > changing cwd is my second least-favorite thing (right after using env vars
to
> > pass state around).
> 
> Again, almost blindly copied over from gcl.py. It looks like there is a --root
> argument. Will give it a try.

--root doesn't do what I think it does, so unless I go fix cpplint.py (which
comes from http://google-styleguide.googlecode.com/), I can't get it to print
chrome/browser/foo if I'm not in the root directory. Instead it will print
../rel_path/to/chrome/browser/foo.

[iannucci, 2014-03-01 20:40:17]

Sorry, fell off my radar. lgtm

[Lei Zhang, 2014-03-11 19:19:44]

The CQ bit was checked by thestig@chromium.org

[commit-bot: I haz the power, 2014-03-11 19:19:56]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/thestig@chromium.org/134223010/150001

[commit-bot: I haz the power, 2014-03-11 19:22:27]

Change committed as 256289