Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(92)

Issue 134223003: A64: Implement LPower and extend MathPowStub to support args in registers (Closed)

Created:
6 years, 11 months ago by jochen (gone - plz use gerrit)
Modified:
6 years, 11 months ago
Reviewers:
baptiste.afsa1, ulan
CC:
v8-dev
Visibility:
Public.

Description

A64: Implement LPower and extend MathPowStub to support args in registers BUG=314606 R=ulan@chromium.org, baptiste.afsa@arm.com Committed: https://code.google.com/p/v8/source/detail?r=18779

Patch Set 1 #

Patch Set 2 : reupload #

Unified diffs Side-by-side diffs Delta from patch set Stats (+93 lines, -19 lines) Patch
M src/a64/code-stubs-a64.cc View 6 chunks +30 lines, -18 lines 0 comments Download
M src/a64/lithium-a64.h View 2 chunks +16 lines, -0 lines 0 comments Download
M src/a64/lithium-a64.cc View 1 chunk +13 lines, -1 line 0 comments Download
M src/a64/lithium-codegen-a64.cc View 1 chunk +34 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
jochen (gone - plz use gerrit)
plz review
6 years, 11 months ago (2014-01-23 12:13:17 UTC) #1
jochen (gone - plz use gerrit)
plz review
6 years, 11 months ago (2014-01-23 12:13:17 UTC) #2
ulan
The diff is empty, could you reupload?
6 years, 11 months ago (2014-01-23 12:27:50 UTC) #3
jochen (gone - plz use gerrit)
done
6 years, 11 months ago (2014-01-23 12:59:59 UTC) #4
ulan
LGTM. A nit about CL description, arm and mips ports usually use "ARM:" and "MIPS:" ...
6 years, 11 months ago (2014-01-23 13:20:35 UTC) #5
jochen (gone - plz use gerrit)
6 years, 11 months ago (2014-01-23 13:51:40 UTC) #6
Message was sent while issue was closed.
Committed patchset #2 manually as r18779 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698