Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(607)

Issue 134223002: fNextIndex is redundant. Remove it. (Closed)

Created:
6 years, 11 months ago by mtklein
Modified:
6 years, 11 months ago
CC:
skia-review_googlegroups.com
Base URL:
https://skia.googlesource.com/skia.git@master
Visibility:
Public.

Description

fNextIndex is redundant. Remove it. This is warmup for removing the NULL at the front. Testing: out/Debug/tests && out/Debug/dm && echo ok BUG=skia:1979 Committed: http://code.google.com/p/skia/source/detail?r=13026

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -14 lines) Patch
M src/core/SkPictureFlat.h View 5 chunks +9 lines, -14 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
mtklein
6 years, 11 months ago (2014-01-10 16:52:30 UTC) #1
Dominik Grewe
On 2014/01/10 16:52:30, mtklein wrote: LGTM, thanks!
6 years, 11 months ago (2014-01-10 17:09:56 UTC) #2
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an ...
6 years, 11 months ago (2014-01-10 17:16:29 UTC) #3
mtklein
6 years, 11 months ago (2014-01-10 17:20:24 UTC) #4
hal.canary
LGTM if the tests all pass.
6 years, 11 months ago (2014-01-10 17:26:38 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/mtklein@google.com/134223002/1
6 years, 11 months ago (2014-01-10 17:26:58 UTC) #6
commit-bot: I haz the power
6 years, 11 months ago (2014-01-10 19:37:03 UTC) #7
Message was sent while issue was closed.
Change committed as 13026

Powered by Google App Engine
This is Rietveld 408576698