Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(537)

Unified Diff: pkg/compiler/lib/src/inferrer/inferrer_visitor.dart

Issue 1342213003: Add optional message to assert in Dart2js - continued (Closed) Base URL: https://github.com/dart-lang/sdk.git@master
Patch Set: Add dart2js test Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pkg/compiler/lib/src/inferrer/inferrer_visitor.dart
diff --git a/pkg/compiler/lib/src/inferrer/inferrer_visitor.dart b/pkg/compiler/lib/src/inferrer/inferrer_visitor.dart
index e542d49d2945624e2b259de679d8abb5409b6096..57d090eb9a8ddbd2f466dd1928d430697d47c0e7 100644
--- a/pkg/compiler/lib/src/inferrer/inferrer_visitor.dart
+++ b/pkg/compiler/lib/src/inferrer/inferrer_visitor.dart
@@ -755,6 +755,14 @@ abstract class InferrerVisitor<T, E extends MinimalInferrerEngine<T>>
T handleDynamicInvoke(Send node);
+ T visitAssert(Assert node) {
+ // Avoid pollution from assert statement unless enabled.
+ if (compiler.enableUserAssertions) {
+ super.visitAssert(node);
+ }
+ return null;
+ }
+
T visitAsyncForIn(AsyncForIn node);
T visitSyncForIn(SyncForIn node);
@@ -793,17 +801,6 @@ abstract class InferrerVisitor<T, E extends MinimalInferrerEngine<T>>
return types.dynamicType;
}
- @override
- T visitAssert(Send node, Node expression, _) {
- if (!compiler.enableUserAssertions) {
- return types.nullType;
- }
- return handleAssert(node, expression);
- }
-
- /// Handle an enabled assertion of [expression].
- T handleAssert(Send node, Node expression);
-
T visitNode(Node node) {
return node.visitChildren(this);
}

Powered by Google App Engine
This is Rietveld 408576698