Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(233)

Unified Diff: sync/engine/sync_session_job.h

Issue 13422003: sync: Refactor job ownership in SyncScheduler (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Fixed upload Created 7 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: sync/engine/sync_session_job.h
diff --git a/sync/engine/sync_session_job.h b/sync/engine/sync_session_job.h
index feb7405f14a54a4baa1cbb7d30770cd618a06ed8..7db96f3c511f650b5ff42bbc0ba6a7dd57d02197 100644
--- a/sync/engine/sync_session_job.h
+++ b/sync/engine/sync_session_job.h
@@ -37,10 +37,6 @@ class SYNC_EXPORT_PRIVATE SyncSessionJob {
const ConfigurationParams& config_params);
~SyncSessionJob();
- // Returns a new clone of the job, with a cloned SyncSession ready to be
- // retried / rescheduled.
- scoped_ptr<SyncSessionJob> Clone() const;
-
// Overwrite the sync update source with the most recent and merge the
// type/state map.
void CoalesceSources(const sessions::SyncSourceInfo& source);
@@ -75,14 +71,6 @@ class SYNC_EXPORT_PRIVATE SyncSessionJob {
ConfigurationParams config_params() const;
private:
- // A SyncSessionJob can be in one of these three states, controlled by the
- // Finish() function, see method comments.
- enum FinishedState {
- NOT_FINISHED, // Finish has not been called.
- EARLY_EXIT, // Finish was called but the job was "preempted",
- FINISHED // Indicates a "clean" finish operation.
- };
-
const Purpose purpose_;
sessions::SyncSourceInfo source_info_;
@@ -92,11 +80,6 @@ class SYNC_EXPORT_PRIVATE SyncSessionJob {
// Succeeded() behavior may be arguments to subclass in the future.
const ConfigurationParams config_params_;
- // Set to true if Finish() was called, false otherwise. True implies that
- // a SyncShare operation took place with |session_| and it cycled through
- // all requisite steps given |purpose_| without being preempted.
- FinishedState finished_;
-
DISALLOW_COPY_AND_ASSIGN(SyncSessionJob);
};

Powered by Google App Engine
This is Rietveld 408576698