sync: Refactor job ownership in SyncScheduler

sync/engine/sync_session_job_unittest.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "sync/engine/sync_session_job.h"
 
 #include "base/bind.h"
 #include "base/bind_helpers.h"
 #include "base/time.h"
 #include "sync/internal_api/public/base/model_type_invalidation_map.h"
@@ skipping 102 matching lines @@
   }
 
  private:
   scoped_ptr<sessions::SyncSessionContext> context_;
   std::vector<scoped_refptr<ModelSafeWorker> > workers_;
   MockDelegate delegate_;
   ModelSafeRoutingInfo routes_;
   bool config_params_callback_invoked_;
 };
 
-TEST_F(SyncSessionJobTest, Clone) {
-  SyncSessionJob job1(SyncSessionJob::NUDGE, TimeTicks::Now(),
-      MakeSourceInfo(), ConfigurationParams());
-
-  scoped_ptr<SyncSession> session1 = MakeSession().Pass();
-  sessions::test_util::SimulateSuccess(session1.get(),
-                                       job1.start_step(),
-                                       job1.end_step());
-  job1.Finish(false, session1.get());
-  ModelSafeRoutingInfo new_routes;
-  new_routes[AUTOFILL] = GROUP_PASSIVE;
-  context()->set_routing_info(new_routes);
-  scoped_ptr<SyncSessionJob> clone1 = job1.Clone();
-
-  ExpectClones(&job1, clone1.get());
-
-  context()->set_routing_info(routes());
-  scoped_ptr<SyncSession> session2 = MakeSession().Pass();
-  sessions::test_util::SimulateSuccess(session2.get(),
-                                       clone1->start_step(),
-                                       clone1->end_step());
-  clone1->Finish(false, session2.get());
-  scoped_ptr<SyncSessionJob> clone2 = clone1->Clone();
-
-  ExpectClones(clone1.get(), clone2.get());
-
-  clone1.reset();
-  ExpectClones(&job1, clone2.get());
-}
-
-TEST_F(SyncSessionJobTest, CloneAfterEarlyExit) {
-  scoped_ptr<SyncSession> session = MakeSession().Pass();
-  SyncSessionJob job1(SyncSessionJob::NUDGE, TimeTicks::Now(),
-      MakeSourceInfo(), ConfigurationParams());
-  job1.Finish(true, session.get());
-  scoped_ptr<SyncSessionJob> job2 = job1.Clone();
-  ExpectClones(&job1, job2.get());
-}
-
-// Tests interaction between Finish and sync cycle success / failure.
-TEST_F(SyncSessionJobTest, Finish) {
-  SyncSessionJob job1(SyncSessionJob::NUDGE, TimeTicks::Now(),
-      MakeSourceInfo(), ConfigurationParams());
-
-  scoped_ptr<SyncSession> session1 = MakeSession().Pass();
-  sessions::test_util::SimulateSuccess(session1.get(),
-                                       job1.start_step(),
-                                       job1.end_step());
-  EXPECT_TRUE(job1.Finish(false /* early_exit */, session1.get()));
-
-  scoped_ptr<SyncSessionJob> job2 = job1.Clone();
-  scoped_ptr<SyncSession> session2 = MakeSession().Pass();
-  sessions::test_util::SimulateConnectionFailure(session2.get(),
-                                                 job2->start_step(),
-                                                 job2->end_step());
-  EXPECT_FALSE(job2->Finish(false, session2.get()));
-}
-
 TEST_F(SyncSessionJobTest, FinishCallsReadyTask) {
   ConfigurationParams params;
   params.ready_task = base::Bind(
       &SyncSessionJobTest::ConfigurationParamsCallback,
       base::Unretained(this));
 
   sessions::SyncSourceInfo info(
       sync_pb::GetUpdatesCallerInfo::RECONFIGURATION,
       ModelTypeInvalidationMap());
   scoped_ptr<SyncSession> session(
@@ skipping 24 matching lines @@
 
   SyncSessionJob job(SyncSessionJob::NUDGE, TimeTicks::Now(),
                      source_one, ConfigurationParams());
 
   job.CoalesceSources(source_two);
 
   EXPECT_EQ(source_two.updates_source, job.source_info().updates_source);
 }
 
 }  // namespace syncer