tools/gn/target.cc - Issue 1342183003: Allow GN configs to have sub-configs.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/gn/target.cc

Issue 1342183003: Allow GN configs to have sub-configs. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: tools/gn/target.cc

diff --git a/tools/gn/target.cc b/tools/gn/target.cc

index 71488cb8a3932ba8a82ad7408dc8fc4ad5aab340..93dbbe2ae851da83f6c4fa72ccf6f18ed3884bba 100644

--- a/tools/gn/target.cc

+++ b/tools/gn/target.cc

@@ -453,7 +453,7 @@ bool Target::ResolvePrecompiledHeaders(Err* err) {

continue; // Skip the one on the target itself.

const Config* config = iter.GetCurrentConfig();

- const ConfigValues& cur = config->config_values();

+ const ConfigValues& cur = config->resolved_values();

if (!cur.has_precompiled_headers())

continue; // This one has no precompiled header info, skip.

« no previous file with comments | « tools/gn/gn.gyp ('k') | tools/gn/target_unittest.cc » ('j') | no next file with comments »