Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(155)

Unified Diff: tools/gn/config.h

Issue 1342183003: Allow GN configs to have sub-configs. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tools/gn/command_desc.cc ('k') | tools/gn/config.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/gn/config.h
diff --git a/tools/gn/config.h b/tools/gn/config.h
index 543d660418776b4d35e281c7e53f9b8c56837b25..20cfe7e40dc208eac3d2509edbcca93a7338d4ac 100644
--- a/tools/gn/config.h
+++ b/tools/gn/config.h
@@ -5,24 +5,59 @@
#ifndef TOOLS_GN_CONFIG_H_
#define TOOLS_GN_CONFIG_H_
+#include "base/logging.h"
#include "base/macros.h"
#include "tools/gn/config_values.h"
#include "tools/gn/item.h"
+#include "tools/gn/label_ptr.h"
+#include "tools/gn/unique_vector.h"
// Represents a named config in the dependency graph.
+//
+// A config can list other configs. We track both the data assigned directly
+// on the config, this list of sub-configs, and (when the config is resolved)
+// the resulting values of everything merged together. The flatten step
+// means we can avoid doing a recursive config walk for every target to compute
+// flags.
class Config : public Item {
public:
Config(const Settings* settings, const Label& label);
~Config() override;
+ // Item implementation.
Config* AsConfig() override;
const Config* AsConfig() const override;
+ bool OnResolved(Err* err) override;
- ConfigValues& config_values() { return config_values_; }
- const ConfigValues& config_values() const { return config_values_; }
+ // The values set directly on this config. This will not contain data from
+ // sub-configs.
+ ConfigValues& own_values() { return own_values_; }
+ const ConfigValues& own_values() const { return own_values_; }
+
+ // The values that represent this config and all sub-configs combined into
+ // one. This is only valid after the config is resolved (when we know the
+ // contents of the sub-configs).
+ const ConfigValues& resolved_values() const {
+ DCHECK(resolved_);
+ if (configs_.empty()) // No sub configs, just use the regular values.
+ return own_values_;
+ return composite_values_;
+ }
+
+ // List of sub-configs.
+ const UniqueVector<LabelConfigPair>& configs() const { return configs_; }
+ UniqueVector<LabelConfigPair>& configs() { return configs_; }
private:
- ConfigValues config_values_;
+ ConfigValues own_values_;
+
+ // Contains the own_values combined with sub-configs. Most configs don't have
+ // sub-configs. So as an optimization, this is not populated if there are no
+ // items in configs_. The resolved_values() getter handles this.
+ bool resolved_;
+ ConfigValues composite_values_;
+
+ UniqueVector<LabelConfigPair> configs_;
DISALLOW_COPY_AND_ASSIGN(Config);
};
« no previous file with comments | « tools/gn/command_desc.cc ('k') | tools/gn/config.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698